Modernize minidialog

Review Request #787 — Created July 3, 2021 and submitted

QuLogic
pidgin/pidgin
default
pidgin
  • Rename LAST_PROPERTY to PROP_LAST.
  • Use GObject macros for declaration.
  • Use GObject macros for definition.
  • Move all internal property handling together.
  • Move class init/finalize together with the rest of GObject implementation.
  • Move callbacks together.
  • Move helpers together (or inline).
  • Add g_return_if_fail(PIDGIN_IS_MINI_DIALOG(...)) on public API.

Compile and connect an account with some buddy requests.

QuLogic
grim
  1. Ship It!
  2. Nice work! While we'll be axing this in the future, still good to see it's warnings get removed!

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...