Summary

Modernize minidialog

Review Request #787 — Created July 3, 2021 and submitted July 3, 2021, 7:45 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description


Rename LAST_PROPERTY to PROP_LAST.
Use GObject macros for declaration.
Use GObject macros for definition.
Move all internal property handling together.
Move class init/finalize together with the rest of GObject implementation.
Move callbacks together.
Move helpers together (or inline).
Add g_return_if_fail(PIDGIN_IS_MINI_DIALOG(...)) on public API.

Testing Done

Compile and connect an account with some buddy requests.

Expand All
Collapse All

Testing Done:: ~
Combine and connect an account with some buddy requests.
~
Compile and connect an account with some buddy requests.

Ship it!

```
Ship It!
```

Nice work! While we'll be axing this in the future, still good to see it's warnings get removed!

Status:: Completed

~		Combine and connect an account with some buddy requests.
	~	Compile and connect an account with some buddy requests.