Move the fuzzers from libpurples/tests to libpurple/fuzzers and cleanup a bunch of little things

Review Request #782 — Created June 25, 2021 and submitted

grim
pidgin/pidgin
release-2.x.y
a21b67e2e1c4
pidgin
Move the fuzzers from libpurples/tests to libpurple/fuzzers and cleanup a bunch of little things

Ran the fuzzers locally

  • 0
  • 0
  • 7
  • 1
  • 8
Description From Last Updated
QuLogic
  1. 
      
  2. FUZZING (Diff revision 1)
     
     
     

    Remove is

  3. FUZZING (Diff revision 1)
     
     

    is built

  4. FUZZING (Diff revision 1)
     
     
     
     
     
     
     

    Does make check not have the dependencies to be called out directly?

    I also kind of expect make check to be running tests, but this is only for build (with good reason outlined in the previous review); maybe we should have a make fuzz alias that does the fuzzer building?

    1. Yeah lets add a fuzz target. I agree that check should be used for running the tests, but I don't want to put the fuzzers in the normal build.

    2. After some digging, looks like it's check or part of the normal build.. I can't figure out how to compile these only when we want to. So in the update, they'll be part of the normal build but won't get installed.

      Although maybe I'm missing something in https://www.gnu.org/software/automake/manual/automake.html#Program-Sources.

    3. Can you add:

      fuzz:
          $(MAKE) -C libpurple/fuzzers check
      
    4. So you're saying, leave it as check_PROGRAMS but then have a target to build them separately even though they're part of check? This seems like more steps for not a lot of gain.

  5. FUZZING (Diff revision 1)
     
     

    Remove by

  6. FUZZING (Diff revision 1)
     
     

    parameter

  7. FUZZING (Diff revision 1)
     
     

    an update

  8. libpurple/fuzzers/fuzz_jabber_id_new.c (Diff revision 1)
     
     

    Break after int.

    1. This one was fixed as well in the last diff.

    2. No it wasn't, i misread which one this was...

  9. 
      
grim
jrchamp
  1. 
      
  2. libpurple/fuzzers/fuzz_jabber_id_new.c (Diff revision 2)
     
     

    I hope this helps: It looks like the other functions have the return type on its own line.

    1. This was already mentioned here and is showing as fixed in my most recent diff for me. Is it not showing as fixed for you?

    2. derp i see it now :-D

    3. ❤️

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...