Move the fuzzers from libpurples/tests to libpurple/fuzzers and cleanup a bunch of little things

 






 

 


  Review Request #782
  —
  Created June 25, 2021 and submitted 

 


















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  release-2.x.y
 









 
 

  
 









 
 

  
 









 
 

  a21b67e2e1c4
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Move the fuzzers from libpurples/tests to libpurple/fuzzers and cleanup a bunch of little things

 








  


 
 

  
Ran the fuzzers locally

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Remove is

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
is built

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Does make check not have the dependencies to be called out directly? I also kind of expect make check to …

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Remove by

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
parameter

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
an update

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Break after int.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
I hope this helps: It looks like the other functions have the return type on its own line.

      		
      
       jrchampjrchamp
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       FUZZING
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Remove is
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       FUZZING
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    is built
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       FUZZING
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Does make check not have the dependencies to be called out directly?
    

    I also kind of expect make check to be running tests, but this is only for build (with good reason outlined in the previous review); maybe we should have a make fuzz alias that does the fuzzer building?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Yeah lets add a fuzz target. I agree that check should be used for running the tests, but I don't want to put the fuzzers in the normal build.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      After some digging, looks like it's check or part of the normal build.. I can't figure out how to compile these only when we want to. So in the update, they'll be part of the normal build but won't get installed.
      

      Although maybe I'm missing something in https://www.gnu.org/software/automake/manual/automake.html#Program-Sources.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Can you add:
      

      fuzz:
    $(MAKE) -C libpurple/fuzzers check

      
 
      

      4. 



    4. 
 
 
      
 
      
  
 
      
 
      
  
      So you're saying, leave it as check_PROGRAMS but then have a target to build them separately even though they're part of check? This seems like more steps for not a lot of gain.
      
 
      

      5. 


 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       FUZZING
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Remove by
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 






  6. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       FUZZING
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    parameter
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 






  7. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       FUZZING
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    an update
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    8. 






  8. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       libpurple/fuzzers/fuzz_jabber_id_new.c
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Break after int.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      This one was fixed as well in the last diff.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      No it wasn't, i misread which one this was...
      
 
      

      3. 


 
    


    

 
    

    9. 




  9. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    10. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




jrchamp




   

   







  

 



 

  


   

   

    
 
jrchamp


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       libpurple/fuzzers/fuzz_jabber_id_new.c
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    I hope this helps: It looks like the other functions have the return type on its own line.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      This was already mentioned here and is showing as fixed in my most recent diff for me. Is it not showing as fixed for you?
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      derp i see it now :-D
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      ❤️
      
 
      

      4. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed