Summary

Move the fuzzers from libpurples/tests to libpurple/fuzzers and cleanup a bunch of little things

Review Request #782 — Created June 24, 2021 and submitted July 8, 2021, 7:21 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

Depends On

Commit

a21b67e2e1c4

Reviewers

Groups

pidgin

People

Description

Move the fuzzers from libpurples/tests to libpurple/fuzzers and cleanup a bunch of little things

Testing Done

Ran the fuzzers locally

Issues

Description	From	Last Updated
Remove is	QuLogic	June 25, 2021, 5:15 p.m.
is built	QuLogic	June 25, 2021, 5:16 p.m.
Does make check not have the dependencies to be called out directly? I also kind of expect make check to …	QuLogic	July 1, 2021, 9:41 p.m.
Remove by	QuLogic	June 25, 2021, 5:16 p.m.
parameter	QuLogic	June 25, 2021, 5:16 p.m.
an update	QuLogic	June 25, 2021, 5:16 p.m.
Break after int.	QuLogic	June 26, 2021, 4:15 a.m.
I hope this helps: It looks like the other functions have the return type on its own line.	jrchamp	June 26, 2021, 2:18 p.m.

FUZZING (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove is
```
FUZZING (Diff revision 1)
The issue has been resolved. Show all issues
```
is built
```

FUZZING (Diff revision 1)

The issue has been dropped. Show all issues

Does make check not have the dependencies to be called out directly?

I also kind of expect make check to be running tests, but this is only for build (with good reason outlined in the previous review); maybe we should have a make fuzz alias that does the fuzzer building?

grim June 25, 2021, 4:32 p.m.

Yeah lets add a fuzz target. I agree that check should be used for running the tests, but I don't want to put the fuzzers in the normal build.

grim June 25, 2021, 4:50 p.m.

After some digging, looks like it's check or part of the normal build.. I can't figure out how to compile these only when we want to. So in the update, they'll be part of the normal build but won't get installed.

Although maybe I'm missing something in https://www.gnu.org/software/automake/manual/automake.html#Program-Sources.

QuLogic June 25, 2021, 5:18 p.m.

Can you add:
fuzz:
    $(MAKE) -C libpurple/fuzzers check

grim June 25, 2021, 5:32 p.m.

So you're saying, leave it as check_PROGRAMS but then have a target to build them separately even though they're part of check? This seems like more steps for not a lot of gain.

FUZZING (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove by
```
FUZZING (Diff revision 1)
The issue has been resolved. Show all issues
```
parameter
```
FUZZING (Diff revision 1)
The issue has been resolved. Show all issues
```
an update
```
libpurple/fuzzers/fuzz_jabber_id_new.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Break after int.
```
1. grim June 25, 2021, 5:33 p.m.
  This one was fixed as well in the last diff.
2. grim June 26, 2021, 4:02 a.m.
  No it wasn't, i misread which one this was...

Commit:

168c93f4f277

b77bb67e6b0c

Diff:

Revision 2 (+149 -116)

Show changes

	.hgignore
	COPYRIGHT
	ChangeLog
	FUZZING
	configure.ac
	libpurple/Makefile.am
	libpurple/fuzzers/Makefile.am
	libpurple/tests/fuzz_html_to_xhtml.c
	8 more

libpurple/fuzzers/fuzz_jabber_id_new.c (Diff revision 2)

The issue has been resolved. Show all issues

I hope this helps: It looks like the other functions have the return type on its own line.

grim June 26, 2021, 3:50 a.m.

This was already mentioned here and is showing as fixed in my most recent diff for me. Is it not showing as fixed for you?

grim June 26, 2021, 4:02 a.m.
```
derp i see it now :-D
```
jrchamp June 26, 2021, 5:07 p.m.
```
❤️
```

Change Summary:

add the newline in the file i missed..

Commit:

b77bb67e6b0c

a21b67e2e1c4

Diff:

Revision 3 (+151 -117)

Show changes

	.hgignore
	COPYRIGHT
	ChangeLog
	FUZZING
	configure.ac
	libpurple/Makefile.am
	libpurple/fuzzers/Makefile.am
	libpurple/tests/fuzz_html_to_xhtml.c
	8 more

Ship it!

```
Ship It!
```

Status:: Completed