Add a blog post describing the devscripts we use for Pidgin 3 development.

Review Request #748 — Created June 13, 2021 and submitted

Information

pidgin/nest
default
add719fbe344

Reviewers

Add a blog post describing the devscripts we use for Pidgin 3 development.

Ran locally


Description From Last Updated

"can be a painful as there's current two command" -> "can be painful as there's currently two command"

sorvivalsorvival

"autotooks" -> "autotools"

sorvivalsorvival

"MacOS" -> "macOS"

sorvivalsorvival

"it's" -> "its"

sorvivalsorvival

"to be passed to" -> "to be passed to the"

sorvivalsorvival

"if your one Mac OS, as well as changing path" -> "if you are on macOS, as well as change …

sorvivalsorvival

"Mac OS" -> "macOS"

sorvivalsorvival

Maybe these should be bullet points linked to the sections below?

QuLogicQuLogic

Probably should rename this variable, as it might be confused with the prefix defined earlier.

QuLogicQuLogic

Based on the paths here, it appears that this script should be run while in a build directory. That doesn't …

QuLogicQuLogic

Ditto on PREFIX.

QuLogicQuLogic

Glade

QuLogicQuLogic

all of which are we should be building?

QuLogicQuLogic
sorvival
  1. 
      
  2. "can be a painful as there's current two command" -> "can be painful as there's currently two command"

    1. what's the suggestion here?

    2. My suggestion is to change "current" to "currently". Now that I look at it again if think we also need to change "there's" to "there are" right?

    3. I looked at this 3 times and didnlty notice the ly... 🤦

    4. not sure wtf a didnlty is and my hands aren't speaking... 🙄

  3. "autotooks" -> "autotools"

    1. I proclaim that from today, autotools will now be known as autotooks!

  4. "MacOS" -> "macOS"

  5. "it's" -> "its"

  6. "to be passed to" -> "to be passed to the"

  7. "if your one Mac OS, as well as changing path" -> "if you are on macOS, as well as change the path"

    1. I had my own typo in my suggestion, the correct one would be:

      "if your one Mac OS, as well as changing path" -> "if you are on macOS, as well as changing the path"

  8. "Mac OS" -> "macOS"

  9. 
      
grim
grim
QuLogic
  1. 
      
  2. hugo/content/post/pidgin3-dev-scripts.md (Diff revision 2)
     
     
     
     
     
     
     

    Maybe these should be bullet points linked to the sections below?

    1. Crap I missed the links 🤦

  3. Probably should rename this variable, as it might be confused with the prefix defined earlier.

  4. Based on the paths here, it appears that this script should be run while in a build directory. That doesn't seem to be mentioned anywhere in this section.

  5. Ditto on PREFIX.

  6. all of which are we should be building?

  7. 
      
grim
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...