Use standard tooltips in XMPP Service Discovery plugin.

Review Request #738 — Created June 10, 2021 and submitted

Information

pidgin/pidgin
default
aae04b645ab3

Reviewers

Use standard tooltips in XMPP Service Discovery plugin.

Opened the plugin's window, and left pointer over the tree to see the tooltips.

Description From Last Updated

Bit more description of what needs implementation pls

relwalretep@gmail.comrelwalretep@gmail.com

need a gtk_tree_path_free() here.

grimgrim

need a gtk_tree_path_free() here.

grimgrim

need a gtk_tree_path_free() here

grimgrim
relwalretep@gmail.com
  1. 
      
  2. pidgin/plugins/disco/gtkdisco.c (Diff revision 1)
     
     
    Show all issues

    Bit more description of what needs implementation pls

    1. I don't actually know what keyboard_mode does. The docs do say that x and y are undefined in that case, but I don't know how to trigger it with the keyboard. Maybe some accessibility shortcut?

    2. Took some googling but ctrl-f1 to trigger the tooltip on a focused widget..

    3. TIL

  3. 
      
grim
  1. 
      
  2. pidgin/plugins/disco/gtkdisco.c (Diff revision 1)
     
     
    Show all issues

    need a gtk_tree_path_free() here.

  3. pidgin/plugins/disco/gtkdisco.c (Diff revision 1)
     
     
    Show all issues

    need a gtk_tree_path_free() here.

  4. 
      
QuLogic
grim
  1. 
      
  2. pidgin/plugins/disco/gtkdisco.c (Diff revision 2)
     
     
    Show all issues

    need a gtk_tree_path_free() here

  3. 
      
QuLogic
grim
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed