Fix some null pointer deferences and dead stores that scanbuild found in Pidgin

Review Request #719 — Created June 3, 2021 and submitted

grim
pidgin/pidgin
release-2.x.y
e040eb4336c8
pidgin
Fix some null pointer deferences and dead stores that scanbuild found in Pidgin

Verified scanbuild no long detected the errors.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
rekkanoryo
  1. 
      
  2. pidgin/gtkblist.c (Diff revision 1)
     
     

    Was width not needed here, or did you just miss breaking it out into its own statement?

    1. If you hit the +20 button when you hover over the line, you'll see it's unconditionally overwritten on line 3151 before the value set on line 3141 is ever read.

  3. 
      
rlaager
  1. Ship It!
  2. 
      
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...