Summary

Fix some null pointer deferences and dead stores that scanbuild found in Pidgin

Review Request #719 — Created June 3, 2021 and submitted June 4, 2021, 12:34 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

Depends On

Commit

e040eb4336c8

Reviewers

Groups

pidgin

People

Description

Fix some null pointer deferences and dead stores that scanbuild found in Pidgin

Testing Done

Verified scanbuild no long detected the errors.

Issues

Description	From	Last Updated
Was width not needed here, or did you just miss breaking it out into its own statement?	rekkanoryo	June 4, 2021, 12:24 a.m.

Expand All
Collapse All

pidgin/gtkblist.c (Diff revision 1)

Show all issues

Was width not needed here, or did you just miss breaking it out into its own statement?

grim June 3, 2021, 1:41 a.m.

If you hit the +20 button when you hover over the line, you'll see it's unconditionally overwritten on line 3151 before the value set on line 3141 is ever read.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Review Board 6.0.2

Fix some null pointer deferences and dead stores that scanbuild found in Pidgin

Information

Reviewers

Status: Closed (submitted)