Summary

Fix some issues scanbuild found in the xmpp protocol plugin

Review Request #711 — Created June 2, 2021 and submitted June 2, 2021, 10:59 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

Depends On

Commit

0b139e724ace

Reviewers

Groups

pidgin

People

Description

Fix some issues scanbuild found in the xmpp protocol plugin

Testing Done

Verified that scanbuild no longer detected the errors.

Issues

Description	From	Last Updated
There's no diff?	QuLogic	June 2, 2021, 8:25 a.m.
This leaks as well.	QuLogic	June 2, 2021, 10:12 a.m.

Status: Discarded

Status: Re-opened

Show all issues

There's no diff?

grim June 2, 2021, 7:55 a.m.

bleh i accidentially discarded it in a draft state so it probably ditched it and i didn't check.. updating.

Commit:

+	fd68bf8d360d

Diff:

Revision 1 (+11 -7)

	libpurple/protocols/jabber/auth_scram.c
	libpurple/protocols/jabber/presence.c
	libpurple/protocols/jabber/google/google_session.c

libpurple/protocols/jabber/auth_scram.c (Diff revision 1)
Show all issues
```
This leaks as well.
```

Commit:

-	fd68bf8d360d
+	0b139e724ace

Diff:

Revision 2 (+14 -10)

Show changes

	libpurple/protocols/jabber/auth_scram.c
	libpurple/protocols/jabber/presence.c
	libpurple/protocols/jabber/google/google_session.c

Ship it!

```
Ship It!
```

Status: Closed (submitted)

libpurple/protocols/jabber/google/google_session.c (Diff revision 2)

grim, the reason this one wasn't triggering a memory leak according to scanbuild is problem because session->state is ALWAYS set to UNINIT by the calling function that allocated the memory.

jrchamp June 4, 2021, 8:15 p.m.

Sorry, that should have been "probably", not "problem".