Fix some issues scanbuild found in the xmpp protocol plugin

Review Request #711 — Created June 2, 2021 and submitted

grim
pidgin/pidgin
release-2.x.y
0b139e724ace
pidgin
Fix some issues scanbuild found in the xmpp protocol plugin
Verified that scanbuild no longer detected the errors.
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
grim
grim
QuLogic
  1. 
      
  2. There's no diff?

    1. bleh i accidentially discarded it in a draft state so it probably ditched it and i didn't check.. updating.

  3. 
      
grim
QuLogic
  1. 
      
  2. libpurple/protocols/jabber/auth_scram.c (Diff revision 1)
     
     

    This leaks as well.

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

jrchamp
  1. 
      
  2. grim, the reason this one wasn't triggering a memory leak according to scanbuild is problem because session->state is ALWAYS set to UNINIT by the calling function that allocated the memory.

    1. Sorry, that should have been "probably", not "problem".
  3. 
      
Loading...