Create a manager for conversations.
Review Request #677 — Created May 28, 2021 and submitted
I Skipped unit tests because need a connection and full protocol implementation to do it properly.
Compiled and ran with an IRC account.
Description | From | Last Updated |
---|---|---|
Do you really need two vars? Seems like g_list_delete_link would work. |
QuLogic | |
Should be l->data, I believe. |
QuLogic | |
Actually, now it seems like purple_conversations_get_all is called multiple times; can you not free here and start from list again … |
QuLogic | |
Extra blank line. |
QuLogic | |
Same comments as the previous function. |
QuLogic | |
gint? |
QuLogic | |
#PurpleConversation\s or something like that? |
QuLogic | |
an |
QuLogic | |
@name |
QuLogic | |
@name |
QuLogic | |
All callers have already checked these things, so they're redundant, except for purple_conversation_manager_find_chat_by_id, which passes name=NULL and is broken by … |
QuLogic | |
!func(conversation, userdata) |
QuLogic | |
The hash table should be freed here? |
QuLogic | |
Don't need the if. |
QuLogic | |
Funny wrap indent. |
QuLogic | |
Funny wrap indent. |
QuLogic | |
Why is this guint instead of gint? |
QuLogic | |
Is gtkblist->menutrayicon not just created in the below deleted code, and thus unused now? |
QuLogic | |
Same questions as in finch. |
QuLogic |
Description: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||
Diff: |
Revision 2 (+560 -404) |
-
-
finch/gntconv.c (Diff revision 2) Do you really need two vars? Seems like
g_list_delete_link
would work. -
-
finch/gntconv.c (Diff revision 2) Actually, now it seems like
purple_conversations_get_all
is called multiple times; can you not free here and start fromlist
again later? I assume the conversation count doesn't change. -
-
-
-
libpurple/purpleconversationmanager.h (Diff revision 2) #PurpleConversation\s
or something like that? -
-
-
-
libpurple/purpleconversationmanager.c (Diff revision 2) All callers have already checked these things, so they're redundant, except for
purple_conversation_manager_find_chat_by_id
, which passesname=NULL
and is broken by thisname != NULL
check. -
-
-
-
-
-
-
pidgin/gtkblist.c (Diff revision 2) Is
gtkblist->menutrayicon
not just created in the below deleted code, and thus unused now? -
Change Summary:
this should be everything found
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+583 -437) |