Add support for the no_proxy environment variable.
Review Request #667 — Created May 25, 2021 and submitted
This started as a patch on https://issues.imfreedom.org/issue/PIDGIN-17518 but I cleaned it up a bit as well.
Followed the unit tests that are documented in the diff.
Description | From | Last Updated |
---|---|---|
Why is this not const also? |
QuLogic | |
I think this is too lax. It needs to check that the suffix starts the string, or is just before … |
QuLogic | |
What should you do if port is an invalid port number? |
QuLogic | |
hostname can never be NULL; it's assigned from items[i] two lines above, which can never be NULL due to the … |
QuLogic | |
entry can never be NULL. |
QuLogic | |
Not really an error? |
QuLogic | |
Not really an error? |
QuLogic | |
On which port? I guess 6667 from the examples. |
QuLogic | |
Set no_proxy_entries = NULL? |
QuLogic |
-
-
-
libpurple/proxy.c (Diff revision 1) I think this is too lax. It needs to check that the suffix starts the string, or is just before a
.
.Right now, if you have
no_proxy=node.net
, that will matchfreenode.net
, and I don't think that's what's wanted? -
-
libpurple/proxy.c (Diff revision 1) hostname
can never beNULL
; it's assigned fromitems[i]
two lines above, which can never beNULL
due to the loop condition. -
-
-
-
-
Change Summary:
rebased and fixed review findings
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+221 -3) |
Change Summary:
make this actually compile, not sure how I missed this previously.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+222 -2) |