Summary

Add support for the no_proxy environment variable.

Review Request #667 — Created May 25, 2021 and submitted June 23, 2021, 12:51 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

PIDGIN-17518

Depends On

Commit

e5ac6a37a937

Reviewers

Groups

pidgin

People

Description

This started as a patch on https://issues.imfreedom.org/issue/PIDGIN-17518
but I cleaned it up a bit as well.

Testing Done

Followed the unit tests that are documented in the diff.

Issues

Description	From	Last Updated
Why is this not const also?	QuLogic	June 22, 2021, 4:21 a.m.
I think this is too lax. It needs to check that the suffix starts the string, or is just before …	QuLogic	June 22, 2021, 4:26 a.m.
What should you do if port is an invalid port number?	QuLogic	June 22, 2021, 4:22 a.m.
hostname can never be NULL; it's assigned from items[i] two lines above, which can never be NULL due to the …	QuLogic	June 22, 2021, 4:23 a.m.
entry can never be NULL.	QuLogic	June 22, 2021, 4:23 a.m.
Not really an error?	QuLogic	June 22, 2021, 4:24 a.m.
Not really an error?	QuLogic	June 22, 2021, 4:24 a.m.
On which port? I guess 6667 from the examples.	QuLogic	June 22, 2021, 4:23 a.m.
Set no_proxy_entries = NULL?	QuLogic	June 22, 2021, 4:22 a.m.

Ship it!

```
Ship It!
```

libpurple/proxy.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Why is this not const also?
```

libpurple/proxy.c (Diff revision 1)

The issue has been resolved. Show all issues

I think this is too lax. It needs to check that the suffix starts the string, or is just before a ..

Right now, if you have no_proxy=node.net, that will match freenode.net, and I don't think that's what's wanted?

AlynxZhou June 8, 2021, 2:25 p.m.

Right, I forget this kind of problem. I think if(purple_strequal(connection->hostname, entry->hostname) || (g_str_has_suffix(connection->hostname, entry->hostname) && connection->hostname[strlen(connection->hostname) - strlen(entry->hostname) - 1] == '.')) { should be fine?

libpurple/proxy.c (Diff revision 1)

The issue has been dropped. Show all issues

What should you do if port is an invalid port number?

AlynxZhou June 8, 2021, 2:25 p.m.

We compare this port with connection's port, and if this port is an invalid port number, it should never equals and will connect with proxy, this is what we want, so it's just fine.

libpurple/proxy.c (Diff revision 1)

The issue has been resolved. Show all issues

hostname can never be NULL; it's assigned from items[i] two lines above, which can never be NULL due to the loop condition.

libpurple/proxy.c (Diff revision 1)
The issue has been resolved. Show all issues
```
entry can never be NULL.
```
libpurple/proxy.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Not really an error?
```
1. AL
  
  AlynxZhou June 8, 2021, 2:25 p.m.
  Yes, not an error I think.
libpurple/proxy.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Not really an error?
```
1. AL
  
  AlynxZhou June 8, 2021, 2:25 p.m.
  Yes, not an error I think.
libpurple/proxy.c (Diff revision 1)
The issue has been resolved. Show all issues
```
On which port? I guess 6667 from the examples.
```
1. AL
  
  AlynxZhou June 8, 2021, 2:25 p.m.
  6667 as following.
libpurple/proxy.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Set no_proxy_entries = NULL?
```