-
-
libpurple/protocols/facebook/facebook.c (Diff revision 1) There are a lot of these in this function; maybe cast once?
-
-
-
libpurple/server.c (Diff revision 1) This probably belongs in the above
ifinstead of repeated, and then you might want aconv/imvariable split like you did below inpurple_serv_got_typing_stopped.
Update purple_conversations_find_* to return PurpleConversations instead of subclasses
Review Request #646 — Created May 12, 2021 and submitted
Update purple_conversations_find_* to return PurpleConversations instead of subclasses
Tested a bonjour im and irc chat.
| Description | From | Last Updated |
|---|---|---|
|
There are a lot of these in this function; maybe cast once? |
 QuLogic
|
|
|
Remove the cast below? |
QuLogic
|
|
|
Probably fits on a single line. |
QuLogic
|
|
|
This probably belongs in the above if instead of repeated, and then you might want a conv/im variable split like … |
QuLogic
|
|
|
Looks like an extra tab got in here. |
QuLogic
|
Change Summary:
Fix issues found in review and a few more warnings I originally missed.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+358 -345) |