Update purple_conversations_find_* to return PurpleConversations instead of subclasses

Review Request #646 — Created May 12, 2021 and submitted

grim
pidgin/pidgin
default
dff889ab06ef
pidgin
Update purple_conversations_find_* to return PurpleConversations instead of subclasses

Tested a bonjour im and irc chat.

Description From Last Updated

There are a lot of these in this function; maybe cast once?

QuLogicQuLogic

Remove the cast below?

QuLogicQuLogic

Probably fits on a single line.

QuLogicQuLogic

This probably belongs in the above if instead of repeated, and then you might want a conv/im variable split like ...

QuLogicQuLogic

Looks like an extra tab got in here.

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/protocols/facebook/facebook.c (Diff revision 1)
     
     

    There are a lot of these in this function; maybe cast once?

  3. libpurple/protocols/gg/message-prpl.c (Diff revision 1)
     
     

    Remove the cast below?

  4. libpurple/protocols/irc/irc.c (Diff revision 1)
     
     
     

    Probably fits on a single line.

  5. libpurple/server.c (Diff revision 1)
     
     
     

    This probably belongs in the above if instead of repeated, and then you might want a conv/im variable split like you did below in purple_serv_got_typing_stopped.

  6. 
      
grim
QuLogic
  1. Ship It!
  2. libpurple/buddyicon.c (Diff revision 2)
     
     

    Looks like an extra tab got in here.

  3. 
      
grim
grim
Review request changed

Status: Closed (submitted)

Loading...