Summary

Update purple_conversations_find_* to return PurpleConversations instead of subclasses

Review Request #646 — Created May 12, 2021 and submitted May 18, 2021, 7:05 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

dff889ab06ef

Reviewers

Groups

pidgin

People

Description

Update purple_conversations_find_* to return PurpleConversations instead of subclasses

Testing Done

Tested a bonjour im and irc chat.

Issues

Description	From	Last Updated
There are a lot of these in this function; maybe cast once?	QuLogic	May 18, 2021, 3:10 a.m.
Remove the cast below?	QuLogic	May 18, 2021, 3:08 a.m.
Probably fits on a single line.	QuLogic	May 18, 2021, 3:08 a.m.
This probably belongs in the above if instead of repeated, and then you might want a conv/im variable split like …	QuLogic	May 18, 2021, 3:10 a.m.
Looks like an extra tab got in here.	QuLogic	May 18, 2021, 7:03 a.m.

libpurple/protocols/facebook/facebook.c (Diff revision 1)
The issue has been resolved. Show all issues
```
There are a lot of these in this function; maybe cast once?
```
libpurple/protocols/gg/message-prpl.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove the cast below?
```
libpurple/protocols/irc/irc.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Probably fits on a single line.
```

libpurple/server.c (Diff revision 1)

The issue has been resolved. Show all issues

This probably belongs in the above if instead of repeated, and then you might want a conv/im variable split like you did below in purple_serv_got_typing_stopped.

Change Summary:

Fix issues found in review and a few more warnings I originally missed.

Commit:

64f1037dfefa

a3dc71113a92

Diff:

Revision 2 (+358 -345)

Show changes

	finch/gntblist.c
	finch/gntconv.c
	libpurple/buddy.c
	libpurple/buddyicon.c
	libpurple/contact.c
	libpurple/conversations.h
	libpurple/conversations.c
	libpurple/protocols.c
	30 more

Ship it!

```
Ship It!
```
libpurple/buddyicon.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Looks like an extra tab got in here.
```