Summary

Add support for osslsigncode and newer versions of nsis

Review Request #588 — Created March 28, 2021 and submitted March 30, 2021, 8:22 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

release-2.x.y

Bugs

PIDGIN-17325, PIDGIN-17402

Depends On

Commit

03b6c27912be

Reviewers

Groups

pidgin

People

Description

Add support for osslsigncode and newer versions of nsis

Testing Done

Built locally on windows with make -f Makefile.mingw installers

Ran the installer in Russian to verify that that issue was fixed as well.

Files

Description:: Add support for osslsigncode and newer versions of nsis
-
-
This may fix the issues with unicode in the installer, but I haven't tested that yet.
Testing Done:: Built locally on windows with make -f Makefile.mingw installers
+
+
Ran the installer in Russian to verify that that issue was fixed as well.
Bugs:: PIDGIN-17325, PIDGIN-17402

Change Summary:

nest a sha256 signature

Commit:

8530fa28782d

03b6c27912be

Diff:

Revision 2 (+15 -2)

Show changes

	Makefile.mingw
	pidgin/win32/nsis/pidgin-installer.nsi

Added Files:

Makefile.mingw (Diff revision 2)

How come there are 3 different timestamp servers?

grim March 29, 2021, 5:35 a.m.

Honestly, I have no idea. I tried to use the one from MONO_SIGN origianlly but it timed out. I assume it's broken and doens't work anymore, but as I didn't want to install mono 2 (what our docs recommened) I didn't test it. Likewise, authenticode requires the windows sdk or something and I didn't look into installing that as I assumed it came with visual studio.

tl;dr I didn't try the other methods.

Ship it!

```
Ship It!
```

I don't do much Windows, so I guess this looks fine.

Status:: Completed

		Add support for osslsigncode and newer versions of nsis
-
-		This may fix the issues with unicode in the installer, but I haven't tested that yet.