Add support for osslsigncode and newer versions of nsis

Review Request #588 — Created March 28, 2021 and submitted

Information

pidgin/pidgin
release-2.x.y
03b6c27912be

Reviewers

Add support for osslsigncode and newer versions of nsis

Built locally on windows with make -f Makefile.mingw installers

Ran the installer in Russian to verify that that issue was fixed as well.


grim
grim
QuLogic
  1. 
      
  2. Makefile.mingw (Diff revision 2)
     
     

    How come there are 3 different timestamp servers?

    1. Honestly, I have no idea. I tried to use the one from MONO_SIGN origianlly but it timed out. I assume it's broken and doens't work anymore, but as I didn't want to install mono 2 (what our docs recommened) I didn't test it. Likewise, authenticode requires the windows sdk or something and I didn't look into installing that as I assumed it came with visual studio.

      tl;dr I didn't try the other methods.

  3. 
      
QuLogic
  1. Ship It!
  2. I don't do much Windows, so I guess this looks fine.

  3. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...