Change Summary:
Added docs and fixed some issues with the docs.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+134 -69) |
Review Request #578 — Created March 22, 2021 and submitted
Add a new macro for exporting the native plugin symbols and use it in the loaders
Compiled and ran the unit tests
Description | From | Last Updated |
---|---|---|
Some parts of this review appear to be missing. The macros are not defined anywhere. |
QuLogic | |
These should define the names of the pre-arranged arguments to the function (or accept args that define the names.) |
QuLogic | |
Change "It should be ..." to "This function should be ..." to match GPLUGIN_(UN)LOAD. |
QuLogic | |
a unique |
QuLogic | |
a unique |
QuLogic | |
a unique |
QuLogic |
Added docs and fixed some issues with the docs.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+134 -69) |
rebased
rev 3 of this rr was accidentally from the wrong, so I rebased and updated the diff from the correct branch..
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+134 -69) |
gplugin/gplugin-native-plugin.c (Diff revision 4) |
---|
These should define the names of the pre-arranged arguments to the function (or accept args that define the names.)
gplugin/gplugin-native-plugin.c (Diff revision 4) |
---|
Change "It should be ..." to "This function should be ..." to match
GPLUGIN_(UN)LOAD
.
updated for the suggested changes, but the api here seems more clunky.. I have an idea to make it better but wanted to update with these changes first.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+134 -69) |
Reworked this into a single macro that then allows plugin authors to use static functions they control which will allows them to use G_GNUC_UNUSED and whatever else they need to.
Summary: |
|
||||||
---|---|---|---|---|---|---|---|
Description: |
|
||||||
Commit: |
|
||||||
Diff: |
Revision 6 (+220 -111) |
build the function names out of the prefix rather than have the user supply them.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+233 -111) |