Avoid manual handling of icons in request field list items

Review Request #563 — Created March 8, 2021 and submitted

Information

pidgin/pidgin
default
a5525f3704b9

Reviewers

  • Use PurpleKeyValuePair as field list items
  • Replace icons list with has_icons flag, thus fixing memleak
  • Replace purple_request_field_list_get_icons with purple_request_field_list_has_icons

Compile and run.

Description From Last Updated

Shows if? Or returns whether?

QuLogicQuLogic

Join brace on if line.

QuLogicQuLogic

I think this should be purple_request_field_list_has_icons if it's just getting a true/false value.

QuLogicQuLogic
QuLogic
  1. 
      
  2. ChangeLog.API (Diff revision 1)
     
     
    Show all issues

    Shows if? Or returns whether?

  3. finch/gntrequest.c (Diff revision 1)
     
     
     
     
    Show all issues

    Join brace on if line.

  4. libpurple/request.h (Diff revision 1)
     
     
    Show all issues

    I think this should be purple_request_field_list_has_icons if it's just getting a true/false value.

  5. 
      
qarkai
qarkai
  1. 
      
  2. ChangeLog.API (Diff revision 2)
     
     

    Don't know why it's still in diff. I've removed this line.

    1. But you didn't? You removed the get_icons -> has_icons one.

    2. Oh, right. I confused get_icons and get_items.

  3. 
      
qarkai
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed