Summary

Avoid manual handling of icons in request field list items

Review Request #563 — Created March 8, 2021 and submitted April 6, 2021, 1:23 a.m.

Information

Owner

qarkai

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

a5525f3704b9

Reviewers

Groups

pidgin

People

Description


Use PurpleKeyValuePair as field list items
Replace icons list with has_icons flag, thus fixing memleak
Replace purple_request_field_list_get_icons with purple_request_field_list_has_icons

Testing Done

Compile and run.

Issues

Description	From	Last Updated
Shows if? Or returns whether?	QuLogic	April 4, 2021, 10:55 a.m.
Join brace on if line.	QuLogic	April 4, 2021, 10:55 a.m.
I think this should be purple_request_field_list_has_icons if it's just getting a true/false value.	QuLogic	April 4, 2021, 10:55 a.m.

ChangeLog.API (Diff revision 1)
The issue has been resolved. Show all issues
```
Shows if? Or returns whether?
```
finch/gntrequest.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Join brace on if line.
```

libpurple/request.h (Diff revision 1)

The issue has been resolved. Show all issues

I think this should be purple_request_field_list_has_icons if it's just getting a true/false value.

Change Summary:


purple_request_field_list_get_icons -> purple_request_field_list_has_icons
add braces

Commit:

ef4fe1d965d6

a5525f3704b9

Diff:

Revision 2 (+69 -82)

Show changes

	ChangeLog.API
	finch/gntrequest.c
	libpurple/request.h
	libpurple/request.c
	libpurple/protocols/silc/chat.c
	pidgin/gtkrequest.c

ChangeLog.API (Diff revision 2)

Don't know why it's still in diff. I've removed this line.

QuLogic April 5, 2021, 7:58 a.m.

But you didn't? You removed the get_icons -> has_icons one.

qarkai April 5, 2021, 8:21 a.m.

Oh, right. I confused get_icons and get_items.

Description:: Use PurpleKeyValuePair as field list items

Replace icons list with has_icons flag, thus fixing memleak
~
Change purple_request_field_list_get_icons return type
~
Replace purple_request_field_list_get_icons with purple_request_field_list_has_icons

Ship it!

```
Ship It!
```

Status:: Completed

		Use `PurpleKeyValuePair` as field list items
		Replace `icons` list with `has_icons` flag, thus fixing memleak
~		Change `purple_request_field_list_get_icons` return type
	~	Replace `purple_request_field_list_get_icons` with `purple_request_field_list_has_icons`