Create a PidginAvatar widget.

Review Request #528 — Created Feb. 26, 2021 and submitted

Information

pidgin/pidgin
default
a942a5e08ded

Reviewers

This does everything the existing code does, but trying to integrate right now
is kind of difficult. The plan is to use this in a new PidginInfoPane I have
started, but that change got very large so I just packed it into the end of
the existing info pane.

The only things that are not implement right now, are making menu items
insensitive and that's because we need to figure out a better want to handle
custom avatars for users.

Ran locally.

Description From Last Updated

The input is transfer full, but data is probably not owned here. I think what that really means that data …

QuLogicQuLogic

displaying

QuLogicQuLogic

Can you not pass the existing GVariant?

QuLogicQuLogic

Extra blank line?

QuLogicQuLogic

Space after |.

QuLogicQuLogic

Why do these call it the 'correct avatar', while PROP_BUDDY calls it 'avatar to be displayed'?

QuLogicQuLogic

whose

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/buddyicon.c (Diff revision 1)
     
     
    Show all issues

    The input is transfer full, but data is probably not owned here. I think what that really means that data must continue to exist as long as the GInputStream does, but I don't know if it is.

    1. This should be fine, as ultimately this stream ends up going to gdk_pixbuf_animation_new_from_stream that just reads it and then we immediately unref the stream.

  3. pidgin/pidginavatar.h (Diff revision 1)
     
     
    Show all issues

    displaying

  4. pidgin/pidginavatar.c (Diff revision 1)
     
     
    Show all issues

    Can you not pass the existing GVariant?

  5. pidgin/pidginavatar.c (Diff revision 1)
     
     
     
    Show all issues

    Extra blank line?

  6. pidgin/pidginavatar.c (Diff revision 1)
     
     
    Show all issues

    Space after |.

  7. pidgin/pidginavatar.c (Diff revision 1)
     
     
     
     
     
     
    Show all issues

    Why do these call it the 'correct avatar', while PROP_BUDDY calls it 'avatar to be displayed'?

  8. 
      
grim
QuLogic
  1. 
      
  2. pidgin/pidginavatar.h (Diff revision 2)
     
     
    Show all issues

    whose

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed