-
-
libpurple/buddyicon.c (Diff revision 1) The input is transfer full, but
datais probably not owned here. I think what that really means thatdatamust continue to exist as long as theGInputStreamdoes, but I don't know if it is. -
-
-
-
-
pidgin/pidginavatar.c (Diff revision 1) Why do these call it the 'correct avatar', while
PROP_BUDDYcalls it 'avatar to be displayed'?
Create a PidginAvatar widget.
Review Request #528 — Created Feb. 26, 2021 and submitted
This does everything the existing code does, but trying to integrate right now
is kind of difficult. The plan is to use this in a new PidginInfoPane I have
started, but that change got very large so I just packed it into the end of
the existing info pane.The only things that are not implement right now, are making menu items
insensitive and that's because we need to figure out a better want to handle
custom avatars for users.
Ran locally.
| Description | From | Last Updated |
|---|---|---|
|
The input is transfer full, but data is probably not owned here. I think what that really means that data … |
 QuLogic
|
|
|
displaying |
QuLogic
|
|
|
Can you not pass the existing GVariant? |
QuLogic
|
|
|
Extra blank line? |
QuLogic
|
|
|
Space after |. |
QuLogic
|
|
|
Why do these call it the 'correct avatar', while PROP_BUDDY calls it 'avatar to be displayed'? |
QuLogic
|
|
|
whose |
QuLogic
|
Description: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 3 (+934) |