Summary

Run update-lastmod script while building container image

Review Request #521 — Created Feb. 19, 2021 and submitted March 3, 2021, 6:05 a.m.

Information

Owner

sorvival

Repository

pidgin/nest

Branch

default

Bugs

NEST-44

Depends On

Commit

fe476cce1682

Reviewers

Groups

pidgin-www

People

Description

This will make sure that the creation date and last modified date of each markdown file matches to what the repository history says

Testing Done

Built container image and verified the added script was indeed getting triggered.
Verified that the script was actually modified the markdown files with the correct creation and last updated date.

Files

Issues

Description	From	Last Updated
Um.. this doesn't seem to be working for me. See the image I attached, I added the paragraph at the …	grim	March 3, 2021, 6:03 a.m.
Is this related?	QuLogic	Feb. 19, 2021, 4:28 a.m.

package-lock.json (Diff revision 1)

Show all issues

Is this related?

sorvival Feb. 19, 2021, 3:34 a.m.

It is. Basically the script that updates the lastmod field on each markdown file depends on the front-matter package. On the other hand, the Dockerfile only installs non-dev dependencies so we need to not mark front-matter as a dev only dep.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Added Files:

Show all issues

Um.. this doesn't seem to be working for me. See the image I attached, I added the paragraph at the start of the image earlier today, but as you can see the modified date still says 2020-01-14.

sorvival Feb. 19, 2021, 5:50 p.m.

Ah I think I know what's going on... the RUN directive where the node script is getting executed currently is in the dockerfile after the static site gets generated. We'll probably have to add another stage in the dockerfile that uses the node:10-buster-slim base image that runs before the static site is actually generated. I'll get to that in a few hours and update this PR

Change Summary:

This new revision should work as intended. Like I said in the comment I left before, the issue was that the update-lastmod.js script needs to be executed BEFORE hugo builds the site as this script modifies the markdown files in case they have an creationDate or lastModifiedDate that does not match the mercurial logs. However, I'm not too sure I like the implementation. An alternative would be to just install node and mercurial in the same stage where we run hugo. I'm open to suggestions to improve this.

Commit:

-	451bc7ca316a
+	fe476cce1682

Diff:

Revision 2 (+18 -3)

Show changes

	.dockerignore
	Dockerfile
	package-lock.json

Yeah this is a bit convoluted, but should be fine for now.

Ship it!

```
Ship It!
```

Review Board 6.0.2

Run update-lastmod script while building container image

Information

Reviewers

Added Files:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)