Implement mitigation for GHSL-2021-045

Review Request #482 — Created Feb. 6, 2021 and submitted

grim
pidgin/pidgin
default
2a5777673660
pidgin

This add a static inline version of g_memdup2 if the version of glib we're
compiling against doesn't have the function.

GHSL-2021-045 was originally reported to glib at
https://gitlab.gnome.org/GNOME/glib/-/issues/2319.

More information about the entire situation can be found on the gnome
desktop-devel-list at
https://mail.gnome.org/archives/desktop-devel-list/2021-February/msg00000.html

Compiled and ran unit tests.

Description From Last Updated

There is a missed g_memdup in libpurple/xfer.c

QuLogicQuLogic

g_memdup2

QuLogicQuLogic
rekkanoryo
  1. Ship It!
  2. 
      
grim
grim
  1. 
      
  2. Forgot to mention that i made some tweaks to upstream code but you can find it here.

    https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1926/diffs#ff06c1d6c2b755129b26deefc1a03b2e2a1a005d_401_417

  3. 
      
QuLogic
  1. Ship It!
  2. libpurple/glibcompat.h (Diff revision 1)
     
     

    g_memdup2

  3. 
      
QuLogic
QuLogic
  1. 
      
  2. There is a missed g_memdup in libpurple/xfer.c

  3. 
      
grim
grim
Review request changed

Status: Closed (submitted)

Loading...