Summary

Implement mitigation for GHSL-2021-045

Review Request #482 — Created Feb. 7, 2021 and submitted Feb. 7, 2021, 7:42 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

2a5777673660

Reviewers

Groups

pidgin

People

Description

This add a static inline version of g_memdup2 if the version of glib we're

compiling against doesn't have the function.
GHSL-2021-045 was originally reported to glib at

https://gitlab.gnome.org/GNOME/glib/-/issues/2319.
More information about the entire situation can be found on the gnome

desktop-devel-list at

https://mail.gnome.org/archives/desktop-devel-list/2021-February/msg00000.html

Testing Done

Compiled and ran unit tests.

Issues

Description	From	Last Updated
There is a missed g_memdup in libpurple/xfer.c	QuLogic	Feb. 7, 2021, 7:09 a.m.
g_memdup2	QuLogic	Feb. 7, 2021, 7:09 a.m.

Ship it!

```
Ship It!
```

Summary:

-	Implementation migitigation for GHSL-2021-045
+	Implement migitigation for GHSL-2021-045

Forgot to mention that i made some tweaks to upstream code but you can find it here.

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1926/diffs#ff06c1d6c2b755129b26deefc1a03b2e2a1a005d_401_417

Ship it!

```
Ship It!
```
libpurple/glibcompat.h (Diff revision 1)
Show all issues
```
g_memdup2
```

Summary:

-	Implement migitigation for GHSL-2021-045
+	Implement mitigation for GHSL-2021-045

Show all issues

There is a missed g_memdup in libpurple/xfer.c

Commit:

-	6635d4e58884
+	2a5777673660

Diff:

Revision 2 (+67 -31)

Show changes

	libpurple/glibcompat.h
	libpurple/image.h
	libpurple/mediamanager.c
	libpurple/request.c
	libpurple/xfer.c
	libpurple/xmlnode.c
	libpurple/protocols/bonjour/buddy.c
	libpurple/protocols/facebook/api.c
	13 more

Review Board 6.0.2

Implement mitigation for GHSL-2021-045

Information

Reviewers

Summary:

Summary:

Commit:

Diff:

Status: Closed (submitted)

libpurple/glibcompat.h (Diff revision 1)