Fix SILC compilation

 






 

 


  Review Request #481
  —
  Created Feb. 6, 2021 and submitted 

 


















 

  

   Information

  





 
 

  qarkai
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  PIDGIN-17436
 









 
 

  
 









 
 

  458fe56f08f4
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
    

  • Move _purple_fstat to silc and rename to silcpurple_fstat
    • 

  • Replace unknown g_fchmod with fchmod
    • 

  • Fix PurpleProtocol* prototypes
    • 

  • Derive SilcPurpleXfer from PurpleXfer
    • 


 








  


 
 

  
Compile.

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
spx is a PurpleXfer subclass, it shouldn't be freed. And spx->hostname is already freed in the _finalize.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
Initialize to NULL.

      		
      
       QuLogicQuLogic
      
      
       
      
     




     

      
       
       
That SILC file is the only one that uses this; I'd rather embed it there instead.

      		
      
       QuLogicQuLogic
      
      
       
      
     


    
   

  

 







 






  

 








 














 



 

  

   




qarkai




   

   

  

 



 















 



 

  

   




qarkai




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      libpurple/protocols/silc/ft.c
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    spx is a PurpleXfer subclass, it shouldn't be freed.
    

    And spx->hostname is already freed in the _finalize.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      libpurple/protocols/silc/silc.c
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Initialize to NULL.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      libpurple/util.h
      


       (Diff revision 2)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    That SILC file is the only one that uses this; I'd rather embed it there instead.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 



 

  

   




qarkai




   

   

  

 



 















 



 

  

   




qarkai




   

   

  

 



 















 





 

  

   




QuLogic




   

   







  

 



 

  


   

   

    
 
QuLogic


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




grim




   

   





  

 



 

  


   

   

    
 
grim


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    




    
    I'll get this merged soonish, but I want to get the silc dependency into at least our subproject build image and freebsd builds so we can make sure it keeps working.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...