Summary

Fix SILC compilation

Review Request #481 — Created Feb. 6, 2021 and submitted Feb. 13, 2021, 5:48 a.m.

Information

Owner

qarkai

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17436

Depends On

Commit

458fe56f08f4

Reviewers

Groups

pidgin

People

Description


Move _purple_fstat to silc and rename to silcpurple_fstat
Replace unknown g_fchmod with fchmod
Fix PurpleProtocol* prototypes
Derive SilcPurpleXfer from PurpleXfer

Testing Done

Compile.

Issues

Description	From	Last Updated
spx is a PurpleXfer subclass, it shouldn't be freed. And spx->hostname is already freed in the _finalize.	QuLogic	Feb. 12, 2021, 3:23 p.m.
Initialize to NULL.	QuLogic	Feb. 12, 2021, 3:23 p.m.
That SILC file is the only one that uses this; I'd rather embed it there instead.	QuLogic	Feb. 12, 2021, 3:23 p.m.

Bugs:: 17436
PIDGIN-17436

Commit:

d872f9c255a7

a52b2b3c7d56

Diff:

Revision 2 (+344 -238)

Show changes

	libpurple/purpleprivate.h
	libpurple/util.h
	libpurple/protocols/silc/buddy.c
	libpurple/protocols/silc/chat.c
	libpurple/protocols/silc/ft.h
	libpurple/protocols/silc/ft.c
	libpurple/protocols/silc/meson.build
	libpurple/protocols/silc/ops.c
	5 more

libpurple/protocols/silc/ft.c (Diff revision 2)

The issue has been resolved. Show all issues

spx is a PurpleXfer subclass, it shouldn't be freed.

And spx->hostname is already freed in the _finalize.

libpurple/protocols/silc/silc.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Initialize to NULL.
```

libpurple/util.h (Diff revision 2)

The issue has been resolved. Show all issues

That SILC file is the only one that uses this; I'd rather embed it there instead.

Commit:

a52b2b3c7d56

458fe56f08f4

Diff:

Revision 3 (+351 -256)

Show changes

	libpurple/purpleprivate.h
	libpurple/util.c
	libpurple/protocols/silc/buddy.c
	libpurple/protocols/silc/chat.c
	libpurple/protocols/silc/ft.h
	libpurple/protocols/silc/ft.c
	libpurple/protocols/silc/meson.build
	libpurple/protocols/silc/ops.c
	5 more

Description:: ~
Make _purple_fstat public
~
Move _purple_fstat to silc and rename to silcpurple_fstat

Replace unknown g_fchmod with fchmod

Fix PurpleProtocol* prototypes

Derive SilcPurpleXfer from PurpleXfer

Ship it!

```
Ship It!
```

I'll get this merged soonish, but I want to get the silc dependency into at least our subproject build image and freebsd builds so we can make sure it keeps working.

Status:: Completed

~		Make `_purple_fstat` public
	~	Move `_purple_fstat` to silc and rename to `silcpurple_fstat`
		Replace unknown `g_fchmod` with `fchmod`
		Fix `PurpleProtocol*` prototypes
		Derive `SilcPurpleXfer` from `PurpleXfer`