Move tzc and zeph02 to own modules and some cleanup

Review Request #471 — Created Jan. 30, 2021 and submitted

Information

pidgin/pidgin
default
ede9936a9005

Reviewers

  • Add send_message, set_location, get_subs_from_server, close to zephyr_account
  • Remove now unused use_tzc and use_zeph02
  • Format message inside zephyr_write_message
  • Rename some functions
  • Reduce scope for some variables
  • Remove unused ZEPHYR_FD_* macros

Compile.

Description From Last Updated

You can put a trailing comma here so it doesn't need to be added later.

QuLogicQuLogic

Extra blank line.

QuLogicQuLogic

Can remove the \n here.

QuLogicQuLogic

Can change this b to buddy as well. Also, drop the \n.

QuLogicQuLogic

Does the header really need this include?

QuLogicQuLogic

Tabs for indent.

QuLogicQuLogic

Tabs for indent.

QuLogicQuLogic

Should mark this function with G_GNUC_PRINTF.

QuLogicQuLogic

Why switch to spaces here?

QuLogicQuLogic

More spaces for indent.

QuLogicQuLogic

Should be const.

QuLogicQuLogic
qarkai
qarkai
qarkai
QuLogic
  1. 
      
  2. libpurple/protocols/zephyr/meson.build (Diff revision 4)
     
     
    Show all issues

    You can put a trailing comma here so it doesn't need to be added later.

  3. libpurple/protocols/zephyr/zephyr.c (Diff revision 4)
     
     
    Show all issues

    Extra blank line.

  4. libpurple/protocols/zephyr/zephyr.c (Diff revision 4)
     
     
    Show all issues

    Can remove the \n here.

  5. libpurple/protocols/zephyr/zephyr.c (Diff revision 4)
     
     
    Show all issues

    Can change this b to buddy as well. Also, drop the \n.

    1. I guess, purple_debug_* don't need \n at all?

    2. Yep, it's automatically added now.

  6. Show all issues

    Does the header really need this include?

    1. Yes, it's for libzephyr symbols.

    2. Ah, I forgot zephyr has its own internal.h.

  7. libpurple/protocols/zephyr/zephyr_account.h (Diff revision 4)
     
     
     
     
     
    Show all issues

    Tabs for indent.

  8. libpurple/protocols/zephyr/zephyr_account.h (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    Tabs for indent.

  9. libpurple/protocols/zephyr/zephyr_tzc.c (Diff revision 4)
     
     
    Show all issues

    Should mark this function with G_GNUC_PRINTF.

  10. libpurple/protocols/zephyr/zephyr_tzc.c (Diff revision 4)
     
     
     
     
    Show all issues

    Why switch to spaces here?

    1. That's "smart" IDE formatting.

  11. libpurple/protocols/zephyr/zephyr_tzc.c (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    More spaces for indent.

  12. Show all issues

    Should be const.

  13. 
      
qarkai
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed