Summary

Move tzc and zeph02 to own modules and some cleanup

Review Request #471 — Created Jan. 30, 2021 and submitted Feb. 4, 2021, 12:28 a.m.

Information

Owner

qarkai

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

ede9936a9005

Reviewers

Groups

pidgin

People

Description


Add send_message, set_location, get_subs_from_server, close to zephyr_account
Remove now unused use_tzc and use_zeph02
Format message inside zephyr_write_message
Rename some functions
Reduce scope for some variables
Remove unused ZEPHYR_FD_* macros

Testing Done

Compile.

Issues

Description	From	Last Updated
You can put a trailing comma here so it doesn't need to be added later.	QuLogic	Feb. 3, 2021, 5:55 p.m.
Extra blank line.	QuLogic	Feb. 3, 2021, 5:55 p.m.
Can remove the \n here.	QuLogic	Feb. 3, 2021, 5:55 p.m.
Can change this b to buddy as well. Also, drop the \n.	QuLogic	Feb. 3, 2021, 5:55 p.m.
Does the header really need this include?	QuLogic	Feb. 3, 2021, 5:56 p.m.
Tabs for indent.	QuLogic	Feb. 3, 2021, 5:55 p.m.
Tabs for indent.	QuLogic	Feb. 3, 2021, 5:55 p.m.
Should mark this function with G_GNUC_PRINTF.	QuLogic	Feb. 3, 2021, 5:55 p.m.
Why switch to spaces here?	QuLogic	Feb. 3, 2021, 5:56 p.m.
More spaces for indent.	QuLogic	Feb. 3, 2021, 5:56 p.m.
Should be const.	QuLogic	Feb. 3, 2021, 5:56 p.m.

Change Summary:

Fix indentation.

Commit:

-	b92be6707292
+	45269b780591

Diff:

Revision 2 (+1201 -1039)

Show changes

	libpurple/protocols/zephyr/meson.build
	libpurple/protocols/zephyr/zephyr.c
	libpurple/protocols/zephyr/zephyr_account.h
	libpurple/protocols/zephyr/zephyr_tzc.h
	libpurple/protocols/zephyr/zephyr_tzc.c
	libpurple/protocols/zephyr/zephyr_zeph02.h
	libpurple/protocols/zephyr/zephyr_zeph02.c

Commit:

-	45269b780591
+	759b30d467ab

Diff:

Revision 3 (+1201 -1039)

Show changes

	libpurple/protocols/zephyr/meson.build
	libpurple/protocols/zephyr/zephyr.c
	libpurple/protocols/zephyr/zephyr_account.h
	libpurple/protocols/zephyr/zephyr_tzc.h
	libpurple/protocols/zephyr/zephyr_tzc.c
	libpurple/protocols/zephyr/zephyr_zeph02.h
	libpurple/protocols/zephyr/zephyr_zeph02.c

Change Summary:

Remove unused ZEPHYR_FD_* macros.

Description:

		Add `send_message`, `set_location`, `get_subs_from_server`, `close` to `zephyr_account`
		Remove now unused `use_tzc` and `use_zeph02`
		Format message inside `zephyr_write_message`
		Rename some functions
		Reduce scope for some variables
	+	Remove unused `ZEPHYR_FD_*` macros

Commit:

-	759b30d467ab
+	25a76f001f3c

Diff:

Revision 4 (+1201 -1041)

Show changes

	libpurple/protocols/zephyr/meson.build
	libpurple/protocols/zephyr/zephyr.c
	libpurple/protocols/zephyr/zephyr_account.h
	libpurple/protocols/zephyr/zephyr_tzc.h
	libpurple/protocols/zephyr/zephyr_tzc.c
	libpurple/protocols/zephyr/zephyr_zeph02.h
	libpurple/protocols/zephyr/zephyr_zeph02.c

libpurple/protocols/zephyr/meson.build (Diff revision 4)

Show all issues

You can put a trailing comma here so it doesn't need to be added later.

libpurple/protocols/zephyr/zephyr.c (Diff revision 4)
Show all issues
```
Extra blank line.
```
libpurple/protocols/zephyr/zephyr.c (Diff revision 4)
Show all issues
```
Can remove the \n here.
```

libpurple/protocols/zephyr/zephyr.c (Diff revision 4)

Show all issues

Can change this b to buddy as well. Also, drop the \n.

qarkai Feb. 3, 2021, 5:54 p.m.

I guess, purple_debug_* don't need \n at all?

QuLogic Feb. 3, 2021, 11:13 p.m.
```
Yep, it's automatically added now.
```

libpurple/protocols/zephyr/zephyr_account.h (Diff revision 4)
Show all issues
```
Does the header really need this include?
```
1. qarkai Feb. 3, 2021, 5:54 p.m.
  Yes, it's for libzephyr symbols.
2. QuLogic Feb. 3, 2021, 11:13 p.m.
  Ah, I forgot zephyr has its own internal.h.
libpurple/protocols/zephyr/zephyr_account.h (Diff revision 4)
Show all issues
```
Tabs for indent.
```

libpurple/protocols/zephyr/zephyr_account.h (Diff revision 4)

Show all issues

Tabs for indent.

libpurple/protocols/zephyr/zephyr_tzc.c (Diff revision 4)
Show all issues
```
Should mark this function with G_GNUC_PRINTF.
```
libpurple/protocols/zephyr/zephyr_tzc.c (Diff revision 4)
Show all issues
```
Why switch to spaces here?
```
1. qarkai Feb. 3, 2021, 5:54 p.m.
  That's "smart" IDE formatting.

libpurple/protocols/zephyr/zephyr_tzc.c (Diff revision 4)

Show all issues

More spaces for indent.

libpurple/protocols/zephyr/zephyr_zeph02.c (Diff revision 4)
Show all issues
```
Should be const.
```

Commit:

-	25a76f001f3c
+	ede9936a9005

Diff:

Revision 5 (+1201 -1042)

Show changes

	libpurple/protocols/zephyr/meson.build
	libpurple/protocols/zephyr/zephyr.c
	libpurple/protocols/zephyr/zephyr_account.h
	libpurple/protocols/zephyr/zephyr_tzc.h
	libpurple/protocols/zephyr/zephyr_tzc.c
	libpurple/protocols/zephyr/zephyr_zeph02.h
	libpurple/protocols/zephyr/zephyr_zeph02.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Move tzc and zeph02 to own modules and some cleanup

Information

Reviewers

Change Summary:

Commit:

Diff:

Commit:

Diff:

Change Summary:

Description:

Commit:

Diff:

Commit:

Diff:

Status: Closed (submitted)