Fix up the XEP-0280 carbons support.

Review Request #462 — Created Jan. 28, 2021 and submitted

grim
pidgin/pidgin
default
fb99fb9d38e3
pidgin, xmpp
My initial port of this wasn't great, this is much better.

sent messages between pidgin2 with gkdr/carbons, conversations on my phone, and pidgin3. I sent messages from all clients and received them on all three clients.

Description From Last Updated

jabber_is_own_account returns TRUE if from is NULL, meaning if it isn't there. Is that what is intended?

QuLogicQuLogic
grim
grim
GE
  1. LGTM

  2. 
      
GE
  1. Ship It!
  2. 
      
QuLogic
  1. 
      
  2. libpurple/protocols/jabber/message.c (Diff revision 2)
     
     

    jabber_is_own_account returns TRUE if from is NULL, meaning if it isn't there. Is that what is intended?

    1. Good catch, XEP-0280 states:

      the 'from' attribute MUST be the Carbons-enabled user's bare JID (e.g., "localpart@domainpart");

  3. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...