Summary

Fix up the XEP-0280 carbons support.

Review Request #462 — Created Jan. 28, 2021 and submitted Jan. 30, 2021, 7:33 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

fb99fb9d38e3

Reviewers

Groups

pidgin, xmpp

People

Description

My initial port of this wasn't great, this is much better.

Testing Done

sent messages between pidgin2 with gkdr/carbons, conversations on my phone, and pidgin3. I sent messages from all clients and received them on all three clients.

Issues

Description	From	Last Updated
jabber_is_own_account returns TRUE if from is NULL, meaning if it isn't there. Is that what is intended?	QuLogic	Jan. 30, 2021, 7:24 a.m.

Groups:: xmpp

Change Summary:

fix an old typo.

Commit:

ec168ffc13eb

2ee6b9f59993

Diff:

Revision 2 (+61 -12)

Show changes

	libpurple/purplemessage.h
	libpurple/protocols/jabber/message.h
	libpurple/protocols/jabber/message.c

```
LGTM
```

Ship it!

```
Ship It!
```

libpurple/protocols/jabber/message.c (Diff revision 2)

The issue has been resolved. Show all issues

jabber_is_own_account returns TRUE if from is NULL, meaning if it isn't there. Is that what is intended?

grim Jan. 29, 2021, 12:52 p.m.

Good catch, XEP-0280 states:

the 'from' attribute MUST be the Carbons-enabled user's bare JID (e.g., "localpart@domainpart");