Use ZSubscription_t in zephyr_triple

Review Request #450 — Created Jan. 24, 2021 and submitted

qarkai
pidgin/pidgin
default
77e242684ca0
pidgin
  • Change some functions to use ZSubscription_t
  • Cleanup redundant zephyr_triple allocations
  • Inline zephyr_subscribe_failed
  • Replace find_sub_by_sub and find_sub_by_id with g_slist_find_custom
  • Rename functions related to zephyr_triple

Compile.

Description From Last Updated

Is this all that subscription_subset is used for? If so, it can be modified a bit and this whole function …

QuLogicQuLogic

zt is equal to the result of new_triple, no need to search the list for it.

QuLogicQuLogic

Move * while you're here.

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/protocols/zephyr/zephyr.c (Diff revision 1)
     
     

    Is this all that subscription_subset is used for? If so, it can be modified a bit and this whole function replaced by g_slist_find_custom.

  3. libpurple/protocols/zephyr/zephyr.c (Diff revision 1)
     
     

    zt is equal to the result of new_triple, no need to search the list for it.

  4. libpurple/protocols/zephyr/zephyr.c (Diff revision 1)
     
     

    Move * while you're here.

  5. 
      
qarkai
qarkai
qarkai
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...