Summary

Use ZSubscription_t in zephyr_triple

Review Request #450 — Created Jan. 24, 2021 and submitted Jan. 25, 2021, 8:35 p.m.

Information

Owner

qarkai

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

77e242684ca0

Reviewers

Groups

pidgin

People

Description


Change some functions to use ZSubscription_t
Cleanup redundant zephyr_triple allocations
Inline zephyr_subscribe_failed
Replace find_sub_by_sub and find_sub_by_id with g_slist_find_custom
Rename functions related to zephyr_triple

Testing Done

Compile.

Issues

Description	From	Last Updated
Is this all that subscription_subset is used for? If so, it can be modified a bit and this whole function …	QuLogic	Jan. 24, 2021, 4:53 p.m.
zt is equal to the result of new_triple, no need to search the list for it.	QuLogic	Jan. 24, 2021, 4:53 p.m.
Move * while you're here.	QuLogic	Jan. 24, 2021, 4:53 p.m.

libpurple/protocols/zephyr/zephyr.c (Diff revision 1)

The issue has been resolved. Show all issues

Is this all that subscription_subset is used for? If so, it can be modified a bit and this whole function replaced by g_slist_find_custom.

libpurple/protocols/zephyr/zephyr.c (Diff revision 1)
The issue has been resolved. Show all issues
```
zt is equal to the result of new_triple, no need to search the list for it.
```
libpurple/protocols/zephyr/zephyr.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Move * while you're here.
```

Description:

~		Change some functions to use ZSubscription_t
~		Cleanup redundant zephyr_triple allocations
	~	Change some functions to use `ZSubscription_t`
	~	Cleanup redundant `zephyr_triple` allocations
	+	Inline `zephyr_subscribe_failed`
	+	Replace `find_sub_by_sub` and `find_sub_by_id` with `g_slist_find_custom`

Commit:

6599714282da

b11f9028f148

Diff:

Revision 2 (+202 -222)

Show changes

libpurple/protocols/zephyr/zephyr.c

Commit:

b11f9028f148

dde34070231f

Diff:

Revision 3 (+206 -222)

Show changes

libpurple/protocols/zephyr/zephyr.c

Change Summary:

Rename functions related to zephyr_triple.

Description:

		Change some functions to use `ZSubscription_t`
		Cleanup redundant `zephyr_triple` allocations
		Inline `zephyr_subscribe_failed`
		Replace `find_sub_by_sub` and `find_sub_by_id` with `g_slist_find_custom`
	+	Rename functions related to `zephyr_triple`

Commit:

dde34070231f

77e242684ca0

Diff:

Revision 4 (+207 -224)

Show changes

libpurple/protocols/zephyr/zephyr.c

Ship it!

```
Ship It!
```

Status:: Completed