Send typing for tzc

Review Request #436 — Created Jan. 19, 2021 and submitted

qarkai
pidgin/pidgin
default
84019f6f998e
pidgin

Send typing for tzc too.

Compile.

Description From Last Updated

Can't we just NULL this in the account and only call the function if it's not NULL rather than have …

grimgrim

You can drop the \n here.

QuLogicQuLogic
grim
  1. 
      
  2. libpurple/protocols/zephyr/zephyr.c (Diff revision 1)
     
     

    Can't we just NULL this in the account and only call the function if it's not NULL rather than have function that does nothing?

    1. Probably tzc function should have some kind of purple_notify_error("tzc doesn't support this action") message.
      Actually not sure why tzc can't send PING message.

    2. If you can't figure out how to send it, there can be a message in the debug log when setting the function pointer, but it definitely doesn't need to notify the user.

    3. Couldn't find any objection against sending PING via tzc.

  3. 
      
QuLogic
  1. 
      
  2. libpurple/protocols/zephyr/zephyr.c (Diff revision 1)
     
     

    You can drop the \n here.

  3. 
      
qarkai
QuLogic
  1. Ship It!
  2. 
      
grim
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...