Summary

Send typing for tzc

Review Request #436 — Created Jan. 19, 2021 and submitted Jan. 24, 2021, 6:56 p.m.

Information

Owner

qarkai

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

84019f6f998e

Reviewers

Groups

pidgin

People

Description

Send typing for tzc too.

Testing Done

Compile.

Issues

Description	From	Last Updated
Can't we just NULL this in the account and only call the function if it's not NULL rather than have …	grim	Jan. 24, 2021, 6:33 a.m.
You can drop the \n here.	QuLogic	Jan. 24, 2021, 6:33 a.m.

libpurple/protocols/zephyr/zephyr.c (Diff revision 1)

The issue has been resolved. Show all issues

Can't we just NULL this in the account and only call the function if it's not NULL rather than have function that does nothing?

qarkai Jan. 22, 2021, 12:52 p.m.

Probably tzc function should have some kind of purple_notify_error("tzc doesn't support this action") message.

Actually not sure why tzc can't send PING message.

QuLogic Jan. 24, 2021, 3:11 a.m.

If you can't figure out how to send it, there can be a message in the debug log when setting the function pointer, but it definitely doesn't need to notify the user.

qarkai Jan. 24, 2021, 6:33 a.m.

Couldn't find any objection against sending PING via tzc.