Remove Google Talk from the XMPP plugin.

 






 

 


  Review Request #435
  —
  Created Jan. 19, 2021 and submitted 

 


















 

  

   Information

  





 
 

  grim
 









 
 

  pidgin/pidgin
 









 
 

  default
 









 
 

  
 









 
 

  
 









 
 

  5aa4cfe702b5
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Google Talk has long been on the deprecated list and with Hangouts getting
retired in June, it seems fitting that we finally remove this code.

 








  


 
 

  
    

  • Compiled locally
    • 

  • Ran the unit tests
    • 

  • Connected an XMPP account
    • 

  • Had an audio call with Pidgin 2
    • 

  • Had a video call with Pidgin 2
    • 


 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Not used anymore.

      		
      
       qarkaiqarkai
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




qarkai




   

   







  

 



 

  


   

   

    
 
qarkai


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      libpurple/protocols/jabber/jabber.h
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Not used anymore.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I tried removing it and it's used all over including in jabber.c.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      It's used only in code like
      

      if (js->vcard_timer != 0)
    g_source_remove(js->vcard_timer);

      

      Since nothing changes vcard_timer other usages are unnecessary.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      Oh I see that now.  I just compiled and didn't pay attention to the errors, but the grep makes it quite clear.
      

      

      grim@spectre:~/p/pidgin/libpurple/protocols/jabber$ grep -r -- "->vcard_timer" *
buddy.c:    if (js->vcard_timer) {
buddy.c:        g_source_remove(js->vcard_timer);
buddy.c:        js->vcard_timer = 0;
jabber.c:   if (js->vcard_timer != 0)
jabber.c:       g_source_remove(js->vcard_timer);

      
 
      

      4. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




grim




   

   

  

 



 















 



 

  

   




grim




   

   

  

 



 















 



 

  

   




grim




   

   

  

 



 















 





 

  

   




qarkai




   

   







  

 



 

  


   

   

    
 
qarkai


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




grim




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...