Summary

zephyr_tzc_escape_msg and zephyr_tzc_deescape_str refactoring

Review Request #434 — Created Jan. 15, 2021 and submitted Jan. 19, 2021, 12:01 a.m.

Information

Owner

qarkai

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

12f17845e9ae

Reviewers

Groups

pidgin

People

Description


Move declarations before implementations. Also slightly change local_zephyr_normalize signature
Early return from functions
Get strlen(message) once
Convert while to for
Simplify escaping
Remove nulling of last char since newmsg already initialized to 0's

Testing Done

Compile.

Issues

Description	From	Last Updated
I don't see this being used earlier to need the prototype?	QuLogic	Jan. 18, 2021, 1:55 p.m.
g_return_... is for incorrect programming; I don't think empty input is incorrect as there are places that explicitly call zephyr_send_message …	QuLogic	Jan. 18, 2021, 1:55 p.m.
Not sure about this one as it comes out of some parsed tree thing; it should probably be an explicit …	QuLogic	Jan. 18, 2021, 1:55 p.m.

Description:

~		Add `zephyr_tzc_escape_msg` declaration and move declarations before implementations. Also slightly change `local_zephyr_normalize` declaration* Early return from functions
~		Get `strlen(message)` once
~		Convert `while` to `for`
~		Simplify escaping
~		Remove nulling of last char since `newmsg` already initialized to 0's
	~	Add `zephyr_tzc_escape_msg` declaration and move declarations before implementations. Also slightly change `local_zephyr_normalize` signature
	~	Early return from functions
	~	Get `strlen(message)` once
	~	Convert `while` to `for`
	~	Simplify escaping
	+	Remove nulling of last char since `newmsg` already initialized to 0's

libpurple/protocols/zephyr/zephyr.c (Diff revision 1)

Show all issues

I don't see this being used earlier to need the prototype?

qarkai Jan. 18, 2021, 1:55 p.m.

I moved it here and there several times. Basicly added for symmetry with zephyr_tzc_deescape_str. Removed.

libpurple/protocols/zephyr/zephyr.c (Diff revision 1)

Show all issues

g_return_... is for incorrect programming; I don't think empty input is incorrect as there are places that explicitly call zephyr_send_message with an empty string. This should be a plain if.

libpurple/protocols/zephyr/zephyr.c (Diff revision 1)

Show all issues

Not sure about this one as it comes out of some parsed tree thing; it should probably be an explicit if as well.

Description:

~		Add `zephyr_tzc_escape_msg` declaration and move declarations before implementations. Also slightly change `local_zephyr_normalize` signature
	~	Move declarations before implementations. Also slightly change `local_zephyr_normalize` signature
		Early return from functions
		Get `strlen(message)` once
		Convert `while` to `for`
		Simplify escaping
		Remove nulling of last char since `newmsg` already initialized to 0's

Commit:

-	fd95bb1e0553
+	12f17845e9ae

Diff:

Revision 2 (+43 -51)

Show changes

libpurple/protocols/zephyr/zephyr.c

Ship it!

```
Ship It!
```

Review Board 6.0.1

zephyr_tzc_escape_msg and zephyr_tzc_deescape_str refactoring

Information

Reviewers

Description:

Description:

Commit:

Diff:

Status: Closed (submitted)