Move the PurpleProtocolServer interface to its own file.

Review Request #418 — Created Jan. 12, 2021 and submitted

Information

pidgin/pidgin
default
920e5c0ee0de

Reviewers

Move the PurpleProtocolServer interface to its own file.

Compiled and ran locally. Connected with bonjour and xmpp without issues.

Description From Last Updated

This is not quite the same, since it assumes that set_public_alias is implemented.

QuLogicQuLogic

Same here.

QuLogicQuLogic

Extra \

QuLogicQuLogic

user's

QuLogicQuLogic

Sets

QuLogicQuLogic

user's

QuLogicQuLogic

user

QuLogicQuLogic

user's

QuLogicQuLogic

its

QuLogicQuLogic

its

QuLogicQuLogic
QuLogic
  1. 
      
  2. libpurple/account.c (Diff revision 1)
     
     
    Show all issues

    This is not quite the same, since it assumes that set_public_alias is implemented.

    1. Yes and there will be a glib_warning about it not being implemented anyways and these interfaces need to be broken into smaller pieces yet as well.

    2. But the failure_cb in the else will not be called.

    3. and it's gone because no one uses this or implements it :-D

      its gone

  3. libpurple/account.c (Diff revision 1)
     
     
    Show all issues

    Same here.

  4. libpurple/protocols/bonjour/bonjour.c (Diff revision 1)
     
     
    Show all issues

    Extra \

  5. libpurple/purpleprotocolserver.h (Diff revision 1)
     
     
    Show all issues

    user's

  6. libpurple/purpleprotocolserver.h (Diff revision 1)
     
     
    Show all issues

    Sets

  7. libpurple/purpleprotocolserver.h (Diff revision 1)
     
     
    Show all issues

    user's

  8. libpurple/purpleprotocolserver.h (Diff revision 1)
     
     
    Show all issues

    user

  9. libpurple/purpleprotocolserver.h (Diff revision 1)
     
     
    Show all issues

    user's

  10. libpurple/purpleprotocolserver.h (Diff revision 1)
     
     
    Show all issues

    its

  11. libpurple/purpleprotocolserver.h (Diff revision 1)
     
     
    Show all issues

    its

  12. 
      
grim
grim
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed