Summary

Move the PurpleProtocolServer interface to its own file.

Review Request #418 — Created Jan. 12, 2021 and submitted Jan. 15, 2021, 4:35 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17458

Depends On

Commit

920e5c0ee0de

Reviewers

Groups

pidgin

People

Description

Move the PurpleProtocolServer interface to its own file.

Testing Done

Compiled and ran locally. Connected with bonjour and xmpp without issues.

Issues

Description	From	Last Updated
This is not quite the same, since it assumes that set_public_alias is implemented.	QuLogic	Jan. 15, 2021, 4:11 a.m.
Same here.	QuLogic	Jan. 15, 2021, 4:11 a.m.
Extra \	QuLogic	Jan. 15, 2021, 4:14 a.m.
user's	QuLogic	Jan. 15, 2021, 4:12 a.m.
Sets	QuLogic	Jan. 15, 2021, 4:12 a.m.
user's	QuLogic	Jan. 15, 2021, 4:13 a.m.
user	QuLogic	Jan. 15, 2021, 4:13 a.m.
user's	QuLogic	Jan. 15, 2021, 4:13 a.m.
its	QuLogic	Jan. 15, 2021, 4:13 a.m.
its	QuLogic	Jan. 15, 2021, 4:29 a.m.

libpurple/account.c (Diff revision 1)

Show all issues

This is not quite the same, since it assumes that set_public_alias is implemented.

grim Jan. 15, 2021, 2:40 a.m.

Yes and there will be a glib_warning about it not being implemented anyways and these interfaces need to be broken into smaller pieces yet as well.

QuLogic Jan. 15, 2021, 3:08 a.m.

But the failure_cb in the else will not be called.

grim Jan. 15, 2021, 3:51 a.m.

and it's gone because no one uses this or implements it :-D

its gone

libpurple/account.c (Diff revision 1)
Show all issues
```
Same here.
```
1. grim Jan. 15, 2021, 2:40 a.m.
  See above.
libpurple/protocols/bonjour/bonjour.c (Diff revision 1)
Show all issues
```
Extra \
```
libpurple/purpleprotocolserver.h (Diff revision 1)
Show all issues
```
user's
```
libpurple/purpleprotocolserver.h (Diff revision 1)
Show all issues
```
Sets
```
libpurple/purpleprotocolserver.h (Diff revision 1)
Show all issues
```
user's
```
libpurple/purpleprotocolserver.h (Diff revision 1)
Show all issues
```
user
```
libpurple/purpleprotocolserver.h (Diff revision 1)
Show all issues
```
user's
```
libpurple/purpleprotocolserver.h (Diff revision 1)
Show all issues
```
its
```
libpurple/purpleprotocolserver.h (Diff revision 1)
Show all issues
```
its
```

Commit:

-	3f6d73239cc6
+	84a007cd7d19

Diff:

Revision 2 (+1306 -669)

Show changes

	doc/reference/libpurple/libpurple-docs.xml
	libpurple/account.c
	libpurple/buddyicon.c
	libpurple/connection.c
	libpurple/group.c
	libpurple/meson.build
	libpurple/protocol.h
	libpurple/protocol.c
	32 more

Change Summary:

removed _[gs]et_public_alias as literally nothing used it nor implemented it.

Commit:

-	84a007cd7d19
+	063bcf0a18a1

Diff:

Revision 3 (+1199 -789)

Show changes

	ChangeLog.API
	doc/reference/libpurple/libpurple-docs.xml
	libpurple/account.h
	libpurple/account.c
	libpurple/buddyicon.c
	libpurple/connection.c
	libpurple/group.c
	libpurple/meson.build
	34 more

Commit:

-	063bcf0a18a1
+	920e5c0ee0de

Diff:

Revision 4 (+1199 -789)

Show changes

	ChangeLog.API
	doc/reference/libpurple/libpurple-docs.xml
	libpurple/account.h
	libpurple/account.c
	libpurple/buddyicon.c
	libpurple/connection.c
	libpurple/group.c
	libpurple/meson.build
	34 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Move the PurpleProtocolServer interface to its own file.

Information

Reviewers

Commit:

Diff:

Change Summary:

Commit:

Diff:

Commit:

Diff:

Status: Closed (submitted)