This change has been marked as completed.

Describe the completed change (optional):

Summary

Split PurpleProtocolChat to its own file and clean up the API.

Review Request #406 — Created Jan. 7, 2021 and submitted 4 years, 2 months ago

Information

Owner

grim*

Repository

pidgin/pidgin

Branch

default

Bugs

17457

Depends On

Commit

fa6fd39b9d6b

Reviewers

Groups

pidgin

People

Description*

Split PurpleProtocolChat to its own file and clean up the API.

Testing Done


Compiled and tested bonjour (not affected) and irc locally.
Built and verified the docs.
verified ninja pidgin-pot was successful.

Issues

Description	From	Last Updated
Remove extra space.	QuLogic	4 years, 2 months ago
Is there a reason for not changing jabber_chat_info directly like in other prpls?	QuLogic	4 years, 2 months ago
Remove extra space.	QuLogic	4 years, 2 months ago
Remove extra space.	QuLogic	4 years, 2 months ago
Instant Chat?	QuLogic	4 years, 2 months ago
PurpleProtocolChat	QuLogic	4 years, 2 months ago
purple_protocol_chat_join()	QuLogic	4 years, 2 months ago
PurpleProtocolChat	QuLogic	4 years, 2 months ago
Add transfer annotation?	QuLogic	4 years, 2 months ago
PurpleProtocolChat	QuLogic	4 years, 2 months ago
PurpleProtocolChat	QuLogic	4 years, 2 months ago
Add transfer annotation?	QuLogic	4 years, 2 months ago
PurpleProtocolChat	QuLogic	4 years, 2 months ago
PurpleProtocolChat	QuLogic	4 years, 2 months ago
PurpleProtocolChat	QuLogic	4 years, 2 months ago
PurpleProtocolChat	QuLogic	4 years, 2 months ago
PurpleProtocolChat	QuLogic	4 years, 2 months ago
Weird alignment	QuLogic	4 years, 2 months ago
There are no open issues

Change Summary:

Rebase on default as this was accdientaly based on the developer docs branch.

Commit:

cac812de1859

878452151744

Diff:

Revision 2 (+748 -495)

Show changes

	doc/reference/libpurple/libpurple-docs.xml
	finch/gntblist.c
	finch/gntconv.c
	libpurple/buddylist.c
	libpurple/chat.c
	libpurple/meson.build
	libpurple/protocol.h
	libpurple/protocol.c
	20 more

Summary:: Split PurpleProtocolChat to it's own file and clean up the API.
Split PurpleProtocolChat to its own file and clean up the API.
Description:: ~
Split PurpleProtocolChat to it's own file and clean up the API.
~
Split PurpleProtocolChat to its own file and clean up the API.

libpurple/protocols/irc/irc.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Remove extra space.
```

libpurple/protocols/jabber/jabber.c (Diff revision 2)

The issue has been resolved. Show all issues

Is there a reason for not changing jabber_chat_info directly like in other prpls?

grim 4 years, 2 months ago

I thought it was called by some other stuff but looks like it isn't. Will fix.

libpurple/protocols/novell/novell.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Remove extra space.
```
libpurple/protocols/novell/novell.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Remove extra space.
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Instant Chat?
```
1. grim 4 years, 2 months ago
  I dunno wtf that is, but I'll fix it :)
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
purple_protocol_chat_join()
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Add transfer annotation?
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
PurpleProtocolChat
```

libpurple/purpleprotocolchat.h (Diff revision 2)

OK...

grim 4 years, 2 months ago

I've got to do a better job of vetting these doc comments during these moves...

libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
Add transfer annotation?
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
The issue has been resolved. Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.c (Diff revision 2)
The issue has been resolved. Show all issues
```
Weird alignment
```

Change Summary:

rebased and fixed issues

Commit:

878452151744

fa6fd39b9d6b

Diff:

Revision 3 (+743 -496)

Show changes

	doc/reference/libpurple/libpurple-docs.xml
	finch/gntblist.c
	finch/gntconv.c
	libpurple/buddylist.c
	libpurple/chat.c
	libpurple/meson.build
	libpurple/protocol.h
	libpurple/protocol.c
	20 more

Ship it!

```
Ship It!
```

Status:: Completed

~		Split PurpleProtocolChat to it's own file and clean up the API.
	~	Split PurpleProtocolChat to its own file and clean up the API.