Summary

Split PurpleProtocolChat to its own file and clean up the API.

Review Request #406 — Created Jan. 7, 2021 and submitted Jan. 11, 2021, 7:53 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

17457

Depends On

Commit

fa6fd39b9d6b

Reviewers

Groups

pidgin

People

Description

Split PurpleProtocolChat to its own file and clean up the API.

Testing Done


Compiled and tested bonjour (not affected) and irc locally.
Built and verified the docs.
verified ninja pidgin-pot was successful.

Issues

Description	From	Last Updated
Remove extra space.	QuLogic	Jan. 11, 2021, 7:06 a.m.
Is there a reason for not changing jabber_chat_info directly like in other prpls?	QuLogic	Jan. 11, 2021, 7:06 a.m.
Remove extra space.	QuLogic	Jan. 11, 2021, 7:07 a.m.
Remove extra space.	QuLogic	Jan. 11, 2021, 7:07 a.m.
Instant Chat?	QuLogic	Jan. 11, 2021, 7:07 a.m.
PurpleProtocolChat	QuLogic	Jan. 11, 2021, 7:08 a.m.
purple_protocol_chat_join()	QuLogic	Jan. 11, 2021, 7:09 a.m.
PurpleProtocolChat	QuLogic	Jan. 11, 2021, 7:09 a.m.
Add transfer annotation?	QuLogic	Jan. 11, 2021, 7:09 a.m.
PurpleProtocolChat	QuLogic	Jan. 11, 2021, 7:09 a.m.
PurpleProtocolChat	QuLogic	Jan. 11, 2021, 7:10 a.m.
Add transfer annotation?	QuLogic	Jan. 11, 2021, 7:10 a.m.
PurpleProtocolChat	QuLogic	Jan. 11, 2021, 7:10 a.m.
PurpleProtocolChat	QuLogic	Jan. 11, 2021, 7:10 a.m.
PurpleProtocolChat	QuLogic	Jan. 11, 2021, 7:10 a.m.
PurpleProtocolChat	QuLogic	Jan. 11, 2021, 7:10 a.m.
PurpleProtocolChat	QuLogic	Jan. 11, 2021, 7:10 a.m.
Weird alignment	QuLogic	Jan. 11, 2021, 7:10 a.m.

Change Summary:

Rebase on default as this was accdientaly based on the developer docs branch.

Commit:

-	cac812de1859
+	878452151744

Diff:

Revision 2 (+748 -495)

Show changes

	doc/reference/libpurple/libpurple-docs.xml
	finch/gntblist.c
	finch/gntconv.c
	libpurple/buddylist.c
	libpurple/chat.c
	libpurple/meson.build
	libpurple/protocol.h
	libpurple/protocol.c
	20 more

Summary:

-	Split PurpleProtocolChat to it's own file and clean up the API.
+	Split PurpleProtocolChat to its own file and clean up the API.

Description:

~		Split PurpleProtocolChat to it's own file and clean up the API.
	~	Split PurpleProtocolChat to its own file and clean up the API.

libpurple/protocols/irc/irc.c (Diff revision 2)
Show all issues
```
Remove extra space.
```

libpurple/protocols/jabber/jabber.c (Diff revision 2)

Show all issues

Is there a reason for not changing jabber_chat_info directly like in other prpls?

grim Jan. 11, 2021, 6:44 a.m.

I thought it was called by some other stuff but looks like it isn't. Will fix.

libpurple/protocols/novell/novell.c (Diff revision 2)
Show all issues
```
Remove extra space.
```
libpurple/protocols/novell/novell.c (Diff revision 2)
Show all issues
```
Remove extra space.
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
Instant Chat?
```
1. grim Jan. 11, 2021, 6:44 a.m.
  I dunno wtf that is, but I'll fix it :)
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
purple_protocol_chat_join()
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
Add transfer annotation?
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
PurpleProtocolChat
```

libpurple/purpleprotocolchat.h (Diff revision 2)

OK...

grim Jan. 11, 2021, 6:44 a.m.

I've got to do a better job of vetting these doc comments during these moves...

libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
Add transfer annotation?
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.h (Diff revision 2)
Show all issues
```
PurpleProtocolChat
```
libpurple/purpleprotocolchat.c (Diff revision 2)
Show all issues
```
Weird alignment
```

Change Summary:

rebased and fixed issues

Commit:

-	878452151744
+	fa6fd39b9d6b

Diff:

Revision 3 (+743 -496)

Show changes

	doc/reference/libpurple/libpurple-docs.xml
	finch/gntblist.c
	finch/gntconv.c
	libpurple/buddylist.c
	libpurple/chat.c
	libpurple/meson.build
	libpurple/protocol.h
	libpurple/protocol.c
	20 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Split PurpleProtocolChat to its own file and clean up the API.

Information

Reviewers

Change Summary:

Commit:

Diff:

Summary:

Description:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)