Summary

zephyr_login refactoring

Review Request #405 — Created Jan. 6, 2021 and submitted Jan. 12, 2021, 2:11 a.m.

Information

Owner

qarkai

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Commit

9cdd1e3315e4

Reviewers

Groups

pidgin

People

Description


Add login_tzc and login_zeph02 functions to remove redundant comparison
Add get_zephyr_realm function to reduce code duplication
Extract some functions
Use FALSE in purple_account_get_bool
Replace read_anyone and read_zsubs variables with functions calls

Testing Done

Compile.

Issues

Description	From	Last Updated
This could be g_strdup(at + 1)	QuLogic	Jan. 11, 2021, 8:38 a.m.
Add braces.	QuLogic	Jan. 11, 2021, 8:38 a.m.

Description:: ~
Add login_tzc and login_zeph02 functions to remove redundant comparison
~
Add get_zephyr_realm function to reduce code duplication
~
Add login_tzc and login_zeph02 functions to remove redundant comparison
~
Add get_zephyr_realm function to reduce code duplication

Extract some functions
~
Use FALSE in purple_account_get_bool
~
Replace read_anyone and read_zsubs variables with functions calls
~
Use FALSE in purple_account_get_bool
~
Replace read_anyone and read_zsubs variables with functions calls

libpurple/protocols/zephyr/zephyr.c (Diff revision 1)
The issue has been resolved. Show all issues
```
This could be g_strdup(at + 1)
```
libpurple/protocols/zephyr/zephyr.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Add braces.
```

Commit:

cc5d038ca37e

9cdd1e3315e4

Diff:

Revision 2 (+228 -217)

Show changes

libpurple/protocols/zephyr/zephyr.c

Ship it!

```
Ship It!
```

Status:: Completed

~		Add login_tzc and login_zeph02 functions to remove redundant comparison
~		Add get_zephyr_realm function to reduce code duplication
	~	Add `login_tzc` and `login_zeph02` functions to remove redundant comparison
	~	Add `get_zephyr_realm` function to reduce code duplication
		Extract some functions
~		Use FALSE in purple_account_get_bool
~		Replace read_anyone and read_zsubs variables with functions calls
	~	Use `FALSE` in `purple_account_get_bool`
	~	Replace `read_anyone` and `read_zsubs` variables with functions calls