-
-
doc/reference/libpurple/code_contributions.xml (Diff revision 1) Change "setup" to "set up" (semantics of how it's used here).
-
doc/reference/libpurple/code_contributions.xml (Diff revision 1) Lose the "so" at the end of this line. Reads better.
-
doc/reference/libpurple/code_contributions.xml (Diff revision 1) I assume the mismatched indent here is for proper formatting behavior?
-
doc/reference/libpurple/code_contributions.xml (Diff revision 1) Might read better if rephrased something like "Do not put anything after the <code>=</code> so that Mercurial will look in the default places for the extensions."
-
-
-
doc/reference/libpurple/code_contributions.xml (Diff revision 1) Should be "Review Board" for consistency with the rest of the text.
-
doc/reference/libpurple/code_contributions.xml (Diff revision 1) The comma here isn't strictly necessary. Not opening an issue here because I can't decide if it reads better with or without the comma.
-
doc/reference/libpurple/code_contributions.xml (Diff revision 1) I'd suggest something more like:
Once you have an account and have logged into our Review Board site, you can begin using RBTools. In your shell, navigate to a Mercurial clone of one of the Pidgin or purple-related projects, then run the <code>rbt login</code> command. You should only need to do this once, unless you change your password or have run the <code>rbt logout</code> command.
-
-
doc/reference/libpurple/code_contributions.xml (Diff revision 1) Do you actually mean to say dry-run here? The rest of this paragraph talks about the actual rebase.
-
-
Update all of the development documentation
Review Request #404 — Created Jan. 5, 2021 and submitted
Add documentation for using our repos and how to contribute to them.
Built the docs locally and verified they look decent.
Description | From | Last Updated |
---|---|---|
Change "setup" to "set up" (semantics of how it's used here). |
|
|
Lose the "so" at the end of this line. Reads better. |
|
|
Might read better if rephrased something like "Do not put anything after the <code>=</code> so that Mercurial will look in … |
|
|
Change "as well as" to "and". |
|
|
Lose the comma here. |
|
|
Should be "Review Board" for consistency with the rest of the text. |
|
|
I'd suggest something more like: Once you have an account and have logged into our Review Board site, you can … |
|
|
Lose the comma |
|
|
Do you actually mean to say dry-run here? The rest of this paragraph talks about the actual rebase. |
|
|
Lose "back" |
|
|
Lose the second "just" |
|
|
I missed this in the initial review, but the comma after "branching point" shouldn't be here either. |
|
Change Summary:
Implement the suggestions from John.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+609) |
-
Looks good. After the last change I note below, should be good to bo.
-
doc/reference/libpurple/code_contributions.xml (Diff revision 2) I missed this in the initial review, but the comma after "branching point" shouldn't be here either.