Summary

Use GdkTexture to wrap GdkPixbuf

Review Request #3537 — Created Sept. 27, 2024 and submitted Sept. 27, 2024, 5:07 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~3536~~

Reviewers

Groups

pidgin

People

Description

This fixes the deprecations with using GdkPixbuf for GtkImage or GtkImage.

Also remove the duplicate setting of the content-fit property.

Testing Done

Compiled only, mostly, as I don't think anything sets avatars yet. But did run with valgrind and check Demo protocol Request Fields, as well as Accounts window.

Commits

Summary	ID
Use GdkTexture to wrap GdkPixbuf This fixes the deprecations with using `GdkPixbuf` for `GtkImage` or `GtkImage. Also remove the duplicate setting of the `content-fit` property.	9a72ae7c703e09dd29ec1e4856f8ff39e0e39199

Issues

Description	From	Last Updated
Filename is only used in this scope, we should probably move it here to avoid unnecessary allocations.	grim	Sept. 27, 2024, 5:05 a.m.

pidgin/pidginaccounteditor.c (Diff revision 1)

The issue has been resolved. Show all issues

Filename is only used in this scope, we should probably move it here to avoid unnecessary allocations.

Change Summary:

Reduce variable scope.

Commits:

	Summary	ID
	Use GdkTexture to wrap GdkPixbuf This fixes the deprecations with using `GdkPixbuf` for `GtkImage` or `GtkImage. Also remove the duplicate setting of the `content-fit` property.	ffe3618496ceee69366e92e4d7ab12d90117f68f
	Use GdkTexture to wrap GdkPixbuf This fixes the deprecations with using `GdkPixbuf` for `GtkImage` or `GtkImage. Also remove the duplicate setting of the `content-fit` property.	9a72ae7c703e09dd29ec1e4856f8ff39e0e39199

Diff:

Revision 2 (+106 -58)

Show changes

	pidgin/gtkrequest.c
	pidgin/pidginaccounteditor.c
	pidgin/pidginavatar.c
	pidgin/resources/avatar.ui

Ship it!

```
Awesome work, thank you so very much!!
```

Status:: Completed