Use a normal GtkWindow for requests dialog

Review Request #3536 — Created Sept. 26, 2024 and submitted

Information

pidgin/pidgin
default

Reviewers

This could be redesigned or refactored in some other way, but this is the
quickest way to silence the deprecation warnings.

There's a minor difference in that the Help button goes at the start of the
GtkCenterBox instead of just at the beginning of the actions (which would
all be on the right by default.)

Also add missing cleanup for the request dialog. This saves a couple hundred
errors from valgrind per Request Fields window from the Demo protocol.

Compiled and checked Demo protocol.

Summary ID
Use a normal GtkWindow for requests dialog
This could be redesigned or refactored in some other way, but this is the quickest way to silence the deprecation warnings. Also add missing cleanup for the request dialog. This saves a couple hundred errors from valgrind per Request Fields window from the Demo protocol.
477bec0f3fbcbbd82e158d3d85da746087e92b85
grim
  1. Great work, thank you for squashing some deprecation warnings!!

  2. 
      
grim
Review request changed
Status:
Completed