Summary

Update Purple.NotificationAddContact to take an id parameter

Review Request #3476 — Created Sept. 10, 2024 and submitted Sept. 10, 2024, 6:08 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17938

Depends On

~~3474~~

Reviewers

Groups

pidgin

People

Description

We also set the account property from the contact if it was not yet already
set.

Testing Done

Ran the unit tests under valgrind and called in the turtles for the rest.

Commits

Summary	ID
Update Purple.NotificationAddContact to take an id parameter We also set the account property from the contact if it was not yet already set.	d3daf5a0d0f499d44f6cf99bc49de91523bc7172

Issues

Description	From	Last Updated
If I'm not mistaken, the account property is not G_PARAM_CONSTRUCT, so I don't think it would be set here before …	QuLogic	Sept. 10, 2024, 6:04 a.m.

libpurple/purplenotificationaddcontact.c (Diff revision 1)

The issue has been resolved. Show all issues

If I'm not mistaken, the account property is not G_PARAM_CONSTRUCT, so I don't think it would be set here before the constructed vfunc, and this condition is always true.

Change Summary:

rebase and change the way we handle the account property

Commits:

	Summary	ID
	Update Purple.NotificationAddContact to take an id parameter We also set the account property from the contact if it was not yet already set.	5188cac9bcb93a61d03c1c9bad2734430741b7e9
	Update Purple.NotificationAddContact to take an id parameter We also set the account property from the contact if it was not yet already set.	d3daf5a0d0f499d44f6cf99bc49de91523bc7172

Diff:

Revision 2 (+70 -14)

Show changes

	libpurple/purplenotification.c
	libpurple/purplenotificationaddcontact.h
	libpurple/purplenotificationaddcontact.c
	libpurple/tests/test_notification_add_contact.c

Ship it!

```
Ship It!
```

Status:: Completed