Summary

First steps of cleaning up the notification API

Review Request #3474 — Created Sept. 9, 2024 and submitted Sept. 10, 2024, 12:52 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17937

Depends On

Blocks

3475, 3476

Reviewers

Groups

pidgin

People

Description


Mark Purple.Notification.new deprecated for Purple.Notification.new_generic
Deprecate Purple.Notification.get_data
Depcreate Purple.Notification.get_type
Make Purple.Notification:account no longer construct only

Testing Done

Ran the unit tests under valgrind and called in the turtles for good measure.

Commits

Summary	ID
First steps of cleaning up the notification API * Mark Purple.Notification.new deprecated for Purple.Notification.new_generic * Deprecate Purple.Notification.get_data * Depcreate Purple.Notification.get_type * Make Purple.Notification:account is no longer construct only	7e67bc3711eb8b92ee2552578b709dd8b4e1697b

Issues

Description	From	Last Updated
s/ran/random/	QuLogic	Sept. 10, 2024, 12:42 a.m.
s/the the/the/	QuLogic	Sept. 10, 2024, 12:42 a.m.
rb is colouring this oddly, so I guess there's a space/tab mix.	QuLogic	Sept. 10, 2024, 12:42 a.m.

Change Summary:: Update styling.
Description:: ~
Mark Purple.Notification.new deprecated for Purple.Notification.new_generic
~
Deprecate Purple.Notification.get_data
~
Depcreate Purple.Notification.get_type
~
Make Purple.Notification:account is no longer construct only
~
Mark Purple.Notification.new deprecated for Purple.Notification.new_generic
~
Deprecate Purple.Notification.get_data
~
Depcreate Purple.Notification.get_type
~
Make Purple.Notification:account no longer construct only

libpurple/purplenotification.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/ran/random/
```
libpurple/purplenotification.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/the the/the/
```
libpurple/purplenotificationmanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
rb is colouring this oddly, so I guess there's a space/tab mix.
```

Change Summary:

rebase and address issues.

Commits:

	Summary	ID
	First steps of cleaning up the notification API * Mark Purple.Notification.new deprecated for Purple.Notification.new_generic * Deprecate Purple.Notification.get_data * Depcreate Purple.Notification.get_type * Make Purple.Notification:account is no longer construct only	434ab72919d9f42b9329c91e54ec3310242bd2b5
	First steps of cleaning up the notification API * Mark Purple.Notification.new deprecated for Purple.Notification.new_generic * Deprecate Purple.Notification.get_data * Depcreate Purple.Notification.get_type * Make Purple.Notification:account is no longer construct only	7e67bc3711eb8b92ee2552578b709dd8b4e1697b

Diff:

Revision 2 (+248 -220)

Show changes

	libpurple/purplenotification.h
	libpurple/purplenotification.c
	libpurple/purplenotificationmanager.c
	libpurple/tests/test_notification.c
	libpurple/tests/test_notification_manager.c

Ship it!

```
Ship It!
```

Status:: Completed

~		Mark Purple.Notification.new deprecated for Purple.Notification.new_generic
~		Deprecate Purple.Notification.get_data
~		Depcreate Purple.Notification.get_type
~		Make Purple.Notification:account is no longer construct only
	~	Mark `Purple.Notification.new` deprecated for `Purple.Notification.new_generic`
	~	Deprecate `Purple.Notification.get_data`
	~	Depcreate `Purple.Notification.get_type`
	~	Make `Purple.Notification:account` no longer construct only