Summary

Only send tags and TAGMSG commands when message-tags has been negotiated

Review Request #3433 — Created Aug. 22, 2024 and submitted Aug. 23, 2024, 3:02 a.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

IBIS-31

Depends On

Reviewers

Groups

pidgin

People

Description

Only send tags and TAGMSG commands when message-tags has been negotiated

Testing Done

Ran the unit tests under valgrind and called in the turtles.

Commits

Summary	ID
Only send tags and TAGMSG commands when message-tags has been negotiated	053e689919b8d23938ba6a563d435339b472609f

Issues

Description	From	Last Updated
Whoops, I just realized, this should maybe say "since 0.7"? Would be the same on line 278.	ivanhoe	Aug. 23, 2024, 2:58 a.m.

Ship it!

```
Ship It!
```

ibis/ibismessage.h (Diff revision 1)

The issue has been dropped. Show all issues

Whoops, I just realized, this should maybe say "since 0.7"? Would be the same on line 278.

grim Aug. 23, 2024, 2:54 a.m.

This gets weird because we changed the signature. Typically speaking most libraries only add Since tags at a stable release. IE a 1.0, but we're not there yet so it could go either way. But I tend to lean towards just leaving it at the version where the symbol was originally introduced.

ivanhoe Aug. 23, 2024, 3:02 a.m.
```
Ok, issue dropped. Ship it.
```

Status:: Completed