Only send tags and TAGMSG commands when message-tags has been negotiated

Review Request #3433 — Created Aug. 23, 2024 and submitted

Information

ibis/ibis
default

Reviewers

Only send tags and TAGMSG commands when message-tags has been negotiated

Ran the unit tests under valgrind and called in the turtles.

Summary ID
Only send tags and TAGMSG commands when message-tags has been negotiated
053e689919b8d23938ba6a563d435339b472609f
Description From Last Updated

Whoops, I just realized, this should maybe say "since 0.7"? Would be the same on line 278.

ivanhoeivanhoe
ivanhoe
  1. Ship It!
  2. 
      
ivanhoe
  1. 
      
  2. ibis/ibismessage.h (Diff revision 1)
     
     
    Show all issues

    Whoops, I just realized, this should maybe say "since 0.7"? Would be the same on line 278.

    1. This gets weird because we changed the signature. Typically speaking most libraries only add Since tags at a stable release. IE a 1.0, but we're not there yet so it could go either way. But I tend to lean towards just leaving it at the version where the symbol was originally introduced.

    2. Ok, issue dropped. Ship it.

  3. 
      
grim
Review request changed
Status:
Completed