Summary

Some cleanups for PidginDisplayItem

Review Request #3177 — Created May 10, 2024 and submitted May 10, 2024, 6:11 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Set the title labels to ellipsize at the end, fix the position of the
notification indicators, and hide the notification indicators when the item is
selected. We're hiding them because a later review request is going to allow
us to show additional widgets on hover and selection.

Testing Done

Ran the turtles and opened a bunch of conversations and notifications. See the screen shots in the review.

Commits

Summary	ID
Some cleanups for for PidginDisplayItem Set the title labels to ellipsize at the end, fix the position of the notification indicators, and hide the notification indicators when the item is selected. We're hiding them because a later review request is going to allow us to show additional widgets on hover and selection.	b5a4fc3d1f37f4a710fc9c69b14e5ce9b8215017

Files

Issues

Description	From	Last Updated
I'm not sure these should be dim; maybe only the non-conversation ones?	QuLogic	May 10, 2024, 5:32 a.m.
I'm not sure if this yalign does anything?	QuLogic	May 10, 2024, 5:32 a.m.

pidgin/resources/display-item.ui (Diff revision 1)

Show all issues

I'm not sure these should be dim; maybe only the non-conversation ones?

pidgin/resources/display-item.ui (Diff revision 1)
Show all issues
```
I'm not sure if this yalign does anything?
```

Change Summary:

Addressed issues.

Commits:

	Summary	ID
	Some cleanups for for PidginDisplayItem Set the title labels to ellipsize at the end, fix the position of the notification indicators, and hide the notification indicators when the item is selected. We're hiding them because a later review request is going to allow us to show additional widgets on hover and selection.	7b257238451406a7a21b9db117be006cb642d2cb
	Some cleanups for for PidginDisplayItem Set the title labels to ellipsize at the end, fix the position of the notification indicators, and hide the notification indicators when the item is selected. We're hiding them because a later review request is going to allow us to show additional widgets on hover and selection.	b5a4fc3d1f37f4a710fc9c69b14e5ce9b8215017

Diff:

Revision 2 (+126 -34)

Show changes

	pidgin/pidgindisplaywindow.c
	pidgin/resources/display-item.ui
	pidgin/resources/display-window.ui
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/style.css

Ship it!

```
Ship It!
```

Change Summary:

Fix typo

Summary:

-	Some cleanups for for PidginDisplayItem
+	Some cleanups for PidginDisplayItem

Ship it!

```
Guess I need to do this again.
```

Review Board 6.0.2

Some cleanups for PidginDisplayItem

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Summary:

Status: Closed (submitted)