Implement IbisMessage.serialize

Review Request #3168 — Created May 7, 2024 and submitted

Information

ibis/ibis
default

Reviewers

Implement IbisMessage.serialize

Ran with the turtles and ran the message unit tests under valgrind.

Summary ID
Implement IbisMessage.serialize
2bafb7b1e7b2e1c657cb212c81f78166ab53edfe
Description From Last Updated

Note you could do this with if(message->params[i+1] == NULL), which would avoid the extra loop to get the length (though …

QuLogicQuLogic

internal

QuLogicQuLogic

I'm a bit confused why this is escaped? Shouldn't it be an actual carriage return/newline?

QuLogicQuLogic
QuLogic
  1. 
      
  2. ibis/ibismessage.c (Diff revision 1)
     
     

    Note you could do this with if(message->params[i+1] == NULL), which would avoid the extra loop to get the length (though it probably doesn't matter too much.)

  3. ibis/ibismessage.c (Diff revision 1)
     
     

    internal

  4. ibis/ibismessage.c (Diff revision 1)
     
     

    I'm a bit confused why this is escaped? Shouldn't it be an actual carriage return/newline?

  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...