Summary

Implement IbisMessage.serialize

Review Request #3168 — Created May 7, 2024 and submitted May 10, 2024, 12:39 a.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

IBIS-3

Depends On

~~3167~~

Blocks

3172, 3169

Reviewers

Groups

pidgin

People

Description

Implement IbisMessage.serialize

Testing Done

Ran with the turtles and ran the message unit tests under valgrind.

Commits

Summary	ID
Implement IbisMessage.serialize	2bafb7b1e7b2e1c657cb212c81f78166ab53edfe

Issues

Description	From	Last Updated
Note you could do this with if(message->params[i+1] == NULL), which would avoid the extra loop to get the length (though …	QuLogic	May 10, 2024, 12:28 a.m.
internal	QuLogic	May 10, 2024, 12:28 a.m.
I'm a bit confused why this is escaped? Shouldn't it be an actual carriage return/newline?	QuLogic	May 10, 2024, 12:29 a.m.

ibis/ibismessage.c (Diff revision 1)

The issue has been resolved. Show all issues

Note you could do this with if(message->params[i+1] == NULL), which would avoid the extra loop to get the length (though it probably doesn't matter too much.)

ibis/ibismessage.c (Diff revision 1)
The issue has been resolved. Show all issues
```
internal
```

ibis/ibismessage.c (Diff revision 1)

The issue has been resolved. Show all issues

I'm a bit confused why this is escaped? Shouldn't it be an actual carriage return/newline?

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Implement IbisMessage.serialize	d5d325aeb4de1fc7a30830a08b03e1431e94735f
	Implement IbisMessage.serialize	2bafb7b1e7b2e1c657cb212c81f78166ab53edfe

Diff:

Revision 2 (+1114 -48)

Show changes

	ibis/ibismessage.h
	ibis/ibismessage.c
	ibis/tests/test_message.c

Ship it!

```
Ship It!
```

Status:: Completed