Change Summary:
Fix some issues and warnings I missed initially.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+698 -256) |
Expose the tag unescape and tags parsing under the IbisTags API
Review Request #3166 — Created May 7, 2024 and submitted
Expose the tag unescape and tags parsing under the IbisTags API
Called in the turtles.
| Summary | ID |
|---|---|
| 972b025becba3196b6a8c0ebf4f9bfb254bdf9d7 |
| Description | From | Last Updated |
|---|---|---|
|
will be returned |
 QuLogic
|
|
|
Shouldn't this not happen because of the g_return_val_if_fail? (though I guess technically that could be optimized out) |
QuLogic
|
|
|
I do know it is set even with zero matches, but it wasn't clear from the docs if this is … |
QuLogic
|
|
|
One more test with invalid escape (e.g., \b->b as in the example from the spec)? |
QuLogic
|
-
-
-
ibis/ibistags.c (Diff revision 2) Shouldn't this not happen because of the
g_return_val_if_fail? (though I guess technically that could be optimized out) -
ibis/ibistags.c (Diff revision 2) I do know it is set even with zero matches, but it wasn't clear from the docs if this is set on error. So maybe this should use
g_clear_pointer? -
ibis/tests/test_tags.c (Diff revision 2) One more test with invalid escape (e.g.,
\b->bas in the example from the spec)?
Change Summary:
Address issues.
Commits: |
|
|||||||
|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+698 -256) |