This change has been marked as completed.

Describe the completed change (optional):

Summary

Expose the tag unescape and tags parsing under the IbisTags API

Review Request #3166 — Created May 7, 2024 and submitted 10 months, 1 week ago

Information

Owner

grim*

Repository

ibis/ibis

Branch

default

Bugs

IBIS-1

Depends On

Blocks

3167

Reviewers

Groups

pidgin

People

Description*

Expose the tag unescape and tags parsing under the IbisTags API

Testing Done

Called in the turtles.

Commits

Summary	ID
Expose the tag unescape and tags parsing under the IbisTags API	972b025becba3196b6a8c0ebf4f9bfb254bdf9d7

Issues

Description	From	Last Updated
will be returned	QuLogic	10 months, 1 week ago
Shouldn't this not happen because of the g_return_val_if_fail? (though I guess technically that could be optimized out)	QuLogic	10 months, 1 week ago
I do know it is set even with zero matches, but it wasn't clear from the docs if this is …	QuLogic	10 months, 1 week ago
One more test with invalid escape (e.g., \b->b as in the example from the spec)?	QuLogic	10 months, 1 week ago
There are no open issues

Change Summary:

Fix some issues and warnings I missed initially.

Commits:

	Summary	ID
	Expose the tag unescape and tags parsing under the IbisTags API	fde0078df34f626a54bb8ef3cff43402e1772977
	Expose the tag unescape and tags parsing under the IbisTags API	877aa53c13ed26fca2f015aedc55fb7b272e5968

Diff:

Revision 2 (+698 -256)

Show changes

	ibis/ibisparser.c
	ibis/ibistags.h
	ibis/ibistags.c
	ibis/meson.build
	ibis/tests/meson.build
	ibis/tests/test_parser.c
	ibis/tests/test_tags.c

ibis/ibistags.h (Diff revision 2)
The issue has been resolved. Show all issues
```
will be returned
```

ibis/ibistags.c (Diff revision 2)

The issue has been resolved. Show all issues

Shouldn't this not happen because of the g_return_val_if_fail? (though I guess technically that could be optimized out)

grim 10 months, 1 week ago

You're right. That said we should probably allow empty string to be passed.

ibis/ibistags.c (Diff revision 2)

The issue has been resolved. Show all issues

I do know it is set even with zero matches, but it wasn't clear from the docs if this is set on error. So maybe this should use g_clear_pointer?

ibis/tests/test_tags.c (Diff revision 2)

The issue has been dropped. Show all issues

One more test with invalid escape (e.g., \b->b as in the example from the spec)?

grim 10 months, 1 week ago

I agree, and we should also be doing the test\ test as well. However, these functions get made private in /r/3167/ so I'm not going to fix it here, but I will go and add the tests in the other rr.

Change Summary:

Address issues.

Commits:

	Summary	ID
	Expose the tag unescape and tags parsing under the IbisTags API	877aa53c13ed26fca2f015aedc55fb7b272e5968
	Expose the tag unescape and tags parsing under the IbisTags API	972b025becba3196b6a8c0ebf4f9bfb254bdf9d7

Diff:

Revision 3 (+698 -256)

Show changes

	ibis/ibisparser.c
	ibis/ibistags.h
	ibis/ibistags.c
	ibis/meson.build
	ibis/tests/meson.build
	ibis/tests/test_parser.c
	ibis/tests/test_tags.c

Ship it!

```
Ship It!
```

Status:: Completed