Summary

Make ibis_message_set_params variadic

Review Request #3165 — Created May 6, 2024 and submitted May 7, 2024, 3:39 a.m.

Information

Owner

grim

Repository

ibis/ibis

Branch

default

Bugs

IBIS-4

Depends On

Reviewers

Groups

pidgin

People

Description

This renames ibis_message_set_params to ibis_message_set_paramsv and
reimplements ibis_message_set_params to use GStrvBuilder to build a GStrv that
is then passed to ibis_message_set_paramsv.

Testing Done

Called in the turtles.

Commits

Summary	ID
Make ibis_message_set_params varaidic This renames ibis_message_set_params to ibis_message_set_paramsv and reimplements ibis_message_set_params to use GStrvBuilder to build a GStrv that is then passed to ibis_message_set_paramsv.	2605864d74f6b50f311f294138cc89aeb8580a19

Issues

Description	From	Last Updated
instance	QuLogic	May 7, 2024, 3:36 a.m.
variadic	QuLogic	May 7, 2024, 3:36 a.m.
variadic	QuLogic	May 7, 2024, 3:36 a.m.

Change Summary:

Fix typo

Summary:

-	Make ibis_message_set_params varaidic
+	Make ibis_message_set_params variadic

ibis/ibismessage.h (Diff revision 1)
Show all issues
```
instance
```
ibis/tests/test_message.c (Diff revision 1)
Show all issues
```
variadic
```
ibis/tests/test_message.c (Diff revision 1)
Show all issues
```
variadic
```

Change Summary:

address issues

Commits:

	Summary	ID
	Make ibis_message_set_params varaidic This renames ibis_message_set_params to ibis_message_set_paramsv and reimplements ibis_message_set_params to use GStrvBuilder to build a GStrv that is then passed to ibis_message_set_paramsv.	854341316d75a9579f2534909363f0fd5da75749
	Make ibis_message_set_params varaidic This renames ibis_message_set_params to ibis_message_set_paramsv and reimplements ibis_message_set_params to use GStrvBuilder to build a GStrv that is then passed to ibis_message_set_paramsv.	2605864d74f6b50f311f294138cc89aeb8580a19

Diff:

Revision 2 (+400 -10)

Show changes

	ibis/ibismessage.h
	ibis/ibismessage.c
	ibis/ibisparser.c
	ibis/tests/meson.build
	ibis/tests/test_message.c

Ship it!

```
Ship It!
```

Review Board 6.0.2

Make ibis_message_set_params variadic

Information

Reviewers

Change Summary:

Summary:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)

ibis/ibismessage.h (Diff revision 1)

ibis/tests/test_message.c (Diff revision 1)

ibis/tests/test_message.c (Diff revision 1)